Conversation
There was a problem hiding this comment.
You need to also add an external_links directive here, so the linking will still work if there are multiple backend dc-.yml files included on the docker-compose line.
There was a problem hiding this comment.
Ok adding container_name to postgres, so I can do external_links here.
|
I'd also modify README.md to mention the postgres directory and add it to the "run everything" example. I also noticed that cadvisor/influx wasn't added in #23, so we should do that as well. |
|
I was able to run all the services through docker and run the juttle programs (as long as I mapped examples into the container, as expected). So I think once the above things are fixed we'll be ready to merge. |
There was a problem hiding this comment.
I believe instead of timestamp here it should be timestamp with time zone which preserves the timezone info. Unfortunately simply timestamp type does not. http://www.postgresql.org/docs/9.2/static/datatype-datetime.html
|
@mstemm another look please, all comments are addressed. |
examples/README.md
Outdated
There was a problem hiding this comment.
Typo here, should be docker-compose -f dc-outrigger.yml -f elastic-newstracker/dc-elastic.yml -f cadvisor-influx/dc-cadvisor-influx.yml -f postgres-diskstats/dc-postgres.yml up
|
Just the one remaining typo then lgtm! |
d370ac9 to
b0c93a1
Compare
|
Fixed typo, rebased, will merge. |
fixes #15
@mstemm please review the docker setup; @VladVega please review the content, it's your initial postgres demo, but dockerized and with the dataset sanitized beyond recognition.
It would be great if one of you stepped through the README to see if it all works for someone who isn't me. Published the image with data:
juttle/postgres_diskstats_data