First draft of the juttle tutorial with github data#15
First draft of the juttle tutorial with github data#15
Conversation
|
How about review by people who're here this week: @rlgomes @go-oleg @davidvgalbraith |
docs/concepts/juttle_tutorial.md
Outdated
|
Overall I think this does a great job of introducing juttle. Some thoughts
|
docs/concepts/juttle_tutorial.md
Outdated
There was a problem hiding this comment.
Might be handy to define small data sets here.
There was a problem hiding this comment.
Could use help with the definition: would it be "data set that can fit in memory of a Node.js process"? what's the cap - 1GB? and how much of that can be used up by the data?
There was a problem hiding this comment.
we could simply link the following:
https://github.com/nodejs/node-v0.x-archive/wiki/FAQ#what-is-the-memory-limit-on-a-node-process
1a2ebfe to
2693646
Compare
|
Addressed the review comments (thanks guys) except these two:
@go-oleg did you mean to just add them as "juttle has these features but tutorial doesn't cover them", or to actually include them in the tutorial? If the latter, i'm not coming up with useful places to put a function here, much less a reducer. There are places where I can utilize a sub. Sections on join and ES are new and need review, @rlgomes and @davidvgalbraith please. @henridf your review would be most welcome, as you fathered the first version of this tutorial (a lot of it stayed true to the original). still todo:
|
|
I was hoping throughout the tutorial, but you're right in that its going to be complicated. Maybe some links at the end of the tutorial along the lines of "go here next":
|
|
A thought for further out - once there is a Google BigQuery adaptor, it would be compelling to use that to pull data rather than use a static file. |
|
TODO:
|
|
As the tutorial work moved to Outrigger, I suppose this PR won’t ever get merged ⇒ closing. @dmehra If I am mistaken, please reopen. |
|
Will reopen because we still want the main tutorial doc merged into juttle for publishing as part of the docs site, I think, so all local docs links would work (and a big part of this doesn't use outrigger). |
@demmer this is still raw, want high level review. Missing:
read file | write elastic?)Ignore exact wording, not ready for review of that level yet. Mainly want review of "does this tutorial cover the right bits of juttle". Most of it came from the old tutorial, with some mods.