rename options for write to match desired naming scheme#101
Merged
Conversation
Contributor
Author
|
@demmer fixing the mess I introduced. |
docs/adapters/file.md
Outdated
Contributor
There was a problem hiding this comment.
I would just write "Maximum number of points that will be written to the file" as the description.
Contributor
|
Two minor suggestions but lgtm. |
Contributor
Author
|
On green will merge all suggestions addressed. |
rlgomes
added a commit
that referenced
this pull request
Jan 4, 2016
rename options for write to match desired naming scheme
mattnibs
pushed a commit
that referenced
this pull request
Jan 20, 2016
logger default display style to json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #100
In my hastiness to get pr #11 in I changed the wrong option to be
bufferLimit resulting in a messy set of options which should be cleared
up now with this PR.