feat(connector): [Gigadat] payouts for gigadat#9889
Merged
likhinbopanna merged 4 commits intomainfrom Oct 17, 2025
Merged
Conversation
kashif-m
requested changes
Oct 17, 2025
Contributor
kashif-m
left a comment
There was a problem hiding this comment.
- Make unstructured types a
Secretin router data and diesel / domain models - Check if wasm changes are needed?
| Connector::Adyenplatform => Ok(Self::Adyenplatform), | ||
| Connector::Cybersource => Ok(Self::Cybersource), | ||
| Connector::Ebanx => Ok(Self::Ebanx), | ||
| Connector::Gigadat => Ok(Self::Gigadat), |
Contributor
There was a problem hiding this comment.
Did we add Gigadat to PayoutConnectors enum?
| is_eligible: payout_attempt.is_eligible, | ||
| unified_code: None, | ||
| unified_message: None, | ||
| payout_connector_metadata: payout_attempt.payout_connector_metadata.clone(), |
Contributor
There was a problem hiding this comment.
Can cloning be avoided here?
Contributor
Author
There was a problem hiding this comment.
it is required here
crates/router/src/core/payouts.rs
Outdated
|
|
||
| // 4. Process data returned by the connector | ||
| let db = &*state.store; | ||
| // let a = router_data.connector_meta_data.clone(); |
crates/router/src/core/payouts.rs
Outdated
| .to_payout_failed_response()? | ||
| } | ||
| false => router_data, | ||
| false => router_data.clone(), |
crates/router/src/core/payouts.rs
Outdated
| let status = payout_response_data | ||
| .status | ||
| .unwrap_or(payout_attempt.status.to_owned()); | ||
| // let a =router_data.connector_meta_data.clone(); |
| pub unified_message: Option<UnifiedMessage>, | ||
| pub additional_payout_method_data: Option<payout_method_utils::AdditionalPayoutMethodData>, | ||
| pub merchant_order_reference_id: Option<String>, | ||
| pub payout_connector_metadata: Option<serde_json::Value>, |
Contributor
There was a problem hiding this comment.
Let's make it SecretSerdeValue instead in diesel models?
crates/router/src/core/utils.rs
Outdated
| connector_transfer_method_id, | ||
| webhook_url: Some(webhook_url), | ||
| browser_info, | ||
| payout_connector_metadata: payout_attempt.payout_connector_metadata.clone(), |
| pub should_add_next_step_to_process_tracker: bool, | ||
| pub error_code: Option<String>, | ||
| pub error_message: Option<String>, | ||
| pub payout_connector_metadata: Option<serde_json::Value>, |
Contributor
There was a problem hiding this comment.
Make this SecretSerdeValue
| pub unified_message: Option<UnifiedMessage>, | ||
| pub additional_payout_method_data: Option<payout_method_utils::AdditionalPayoutMethodData>, | ||
| pub merchant_order_reference_id: Option<String>, | ||
| pub payout_connector_metadata: Option<serde_json::Value>, |
Contributor
Author
Wasm changes is already done in previous PR |
deepanshu-iiitu
requested changes
Oct 17, 2025
| fn try_from( | ||
| item: PayoutsResponseRouterData<F, GigadatPayoutQuoteResponse>, | ||
| ) -> Result<Self, Self::Error> { | ||
| let connector_meta = serde_json::json!(GigadatPayoutMeta { |
Contributor
There was a problem hiding this comment.
Add GigadatPayoutMeta validation to validate_auth_and_metadata_type_with_connector and in WASM files
Contributor
Author
There was a problem hiding this comment.
its already added in previous PR
kashif-m
approved these changes
Oct 17, 2025
sai-harsha-vardhan
approved these changes
Oct 17, 2025
deepanshu-iiitu
approved these changes
Oct 17, 2025
drdholu
pushed a commit
to drdholu/hyperswitch
that referenced
this pull request
Oct 30, 2025
aadityaguptaa
pushed a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implement Payouts for Gigadat Connector
Additional Changes
Motivation and Context
How did you test it?
Create Payout connector (Gigadat)
Response
We will get pending status, as per doc in sbx we can not fullfill the payouts.
Checklist
cargo +nightly fmt --allcargo clippy