Skip to content

feat(framework): Diesel and domain model changes to support multiple outgoing webhooks#9816

Merged
Gnanasundari24 merged 5 commits intomainfrom
mul-webhooks/db-domain-changes
Oct 16, 2025
Merged

feat(framework): Diesel and domain model changes to support multiple outgoing webhooks#9816
Gnanasundari24 merged 5 commits intomainfrom
mul-webhooks/db-domain-changes

Conversation

@swetasharma03
Copy link
Contributor

@swetasharma03 swetasharma03 commented Oct 13, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added the multiple_webhook_detail field to the Profile DB and domain model. Also populated these fields to as None.
Also we need webhook_endpoint_id, added support for this idType as well in this PR.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Only domain and diesel model changes (addition of fields only and no values populated), hence no testing required.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@swetasharma03 swetasharma03 self-assigned this Oct 13, 2025
@swetasharma03 swetasharma03 requested review from a team as code owners October 13, 2025 15:05
@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 13, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/common_enums/src/enums.rs  0% smaller
  crates/common_utils/src/id_type.rs  0% smaller
  crates/common_utils/src/id_type/webhook_endpoint.rs  0% smaller
  crates/diesel_models/src/business_profile.rs  0% smaller
  crates/router/src/db/events.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller

@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Oct 13, 2025
@swetasharma03 swetasharma03 force-pushed the mul-webhooks/db-domain-changes branch 3 times, most recently from ca00095 to 40344fe Compare October 13, 2025 16:34
strum::EnumString,
ToSchema,
)]
#[router_derive::diesel_enum(storage_type = "db_enum")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this attribute macro / annotation if we are not using this enum within a column of a database table.

@hyperswitch-bot hyperswitch-bot bot removed the M-database-changes Metadata: This PR involves database schema changes label Oct 14, 2025
@swetasharma03 swetasharma03 force-pushed the mul-webhooks/db-domain-changes branch 2 times, most recently from e96c3b2 to 0e43e5f Compare October 14, 2025 09:58
@swetasharma03 swetasharma03 changed the title feat(core): Diesel and domain model changes to support multiple outgoing webhooks feat(framework): Diesel and domain model changes to support multiple outgoing webhooks Oct 14, 2025
@swetasharma03 swetasharma03 force-pushed the mul-webhooks/db-domain-changes branch from 3cfc1e7 to 487fbaf Compare October 15, 2025 07:56
@swetasharma03 swetasharma03 force-pushed the mul-webhooks/db-domain-changes branch from a2aaa1d to aac36d2 Compare October 15, 2025 10:35
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit ac8c6c9 Oct 16, 2025
29 of 33 checks passed
@Gnanasundari24 Gnanasundari24 deleted the mul-webhooks/db-domain-changes branch October 16, 2025 10:36
chaitak-gorai pushed a commit that referenced this pull request Oct 16, 2025
@swetasharma03 swetasharma03 restored the mul-webhooks/db-domain-changes branch October 17, 2025 18:17
@swetasharma03 swetasharma03 deleted the mul-webhooks/db-domain-changes branch October 17, 2025 18:22
@SanchithHegde SanchithHegde added the A-framework Area: Framework label Oct 19, 2025
@SanchithHegde SanchithHegde added the A-webhooks Area: Webhook flows label Oct 19, 2025
drdholu pushed a commit to drdholu/hyperswitch that referenced this pull request Oct 30, 2025
aadityaguptaa pushed a commit that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-framework Area: Framework A-webhooks Area: Webhook flows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants