fix(routing): cache redaction on updation of mca#9729
Merged
likhinbopanna merged 6 commits intomainfrom Oct 8, 2025
Merged
Conversation
Changed Files
|
14 tasks
Sarthak1799
previously approved these changes
Oct 7, 2025
Sarthak1799
approved these changes
Oct 8, 2025
ShankarSinghC
approved these changes
Oct 8, 2025
UdayPandey01
pushed a commit
to UdayPandey01/hyperswitch
that referenced
this pull request
Oct 8, 2025
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
aadityaguptaa
pushed a commit
that referenced
this pull request
Nov 10, 2025
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pull request refactors how the default fallback routing configuration is updated when a merchant connector account is modified. Instead of calling the old helper function, the logic is now handled through a new
MerchantDefaultConfigUpdatestruct with methods that more explicitly update or remove the connector from the routing algorithm, depending on whether the connector is disabled. The changes also ensure that the connector update uses a clone of the merchant connector account object.Routing configuration update refactor:
update_default_fallback_on_mca_updatehelper with explicit logic using theMerchantDefaultConfigUpdatestruct, which updates or deletes the connector from the default fallback routing algorithm based on the connector's status. This makes the update process more modular and easier to maintain. [1] [2]update_default_fallback_on_mca_updatefunction fromrouting/helpers.rs.Code quality and correctness:
update_merchant_connector_accountcall receives a clone of themcaobject, preventing potential issues with ownership or mutation.update_default_fallback_on_mca_updateimport.Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy