feat(connector): [Loonio] implement payouts#9718
Merged
likhinbopanna merged 9 commits intomainfrom Oct 8, 2025
Merged
Conversation
deepanshu-iiitu
previously approved these changes
Oct 8, 2025
Sakilmostak
requested changes
Oct 8, 2025
| PaymentMethodType::Interac => Self::Interac(api_models::payouts::Interac { | ||
| email: value1.email, | ||
| }), | ||
| _ => Err(errors::VaultError::PayoutMethodNotSupported) |
Contributor
There was a problem hiding this comment.
nit: you can use if let here
| api_models::payouts::PayoutMethodData::Bank(_) => Self::BankTransfer, | ||
| api_models::payouts::PayoutMethodData::Card(_) => Self::Card, | ||
| api_models::payouts::PayoutMethodData::Wallet(_) => Self::Wallet, | ||
| api_models::payouts::PayoutMethodData::BankRedirect(_) => Self::BankTransfer, |
Contributor
There was a problem hiding this comment.
should it be matched to bankredirect?
| api_models::enums::PayoutType::Bank => Self::BankTransfer, | ||
| api_models::enums::PayoutType::Card => Self::Card, | ||
| api_models::enums::PayoutType::Wallet => Self::Wallet, | ||
| api_models::enums::PayoutType::BankRedirect => Self::BankTransfer, |
| api_models::payouts::PayoutMethodData::Bank(_) => Self::Bank, | ||
| api_models::payouts::PayoutMethodData::Card(_) => Self::Card, | ||
| api_models::payouts::PayoutMethodData::Wallet(_) => Self::Wallet, | ||
| api_models::payouts::PayoutMethodData::BankRedirect(_) => Self::Bank, |
Contributor
There was a problem hiding this comment.
shouldn't bank redirect be a separate variant
Sakilmostak
approved these changes
Oct 8, 2025
deepanshu-iiitu
approved these changes
Oct 8, 2025
Sarthak1799
approved these changes
Oct 8, 2025
Contributor
Sarthak1799
left a comment
There was a problem hiding this comment.
Routing changes LGTM
sai-harsha-vardhan
approved these changes
Oct 8, 2025
aadityaguptaa
pushed a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
implement payouts for Loonio
Additional Changes
Motivation and Context
How did you test it?
Create Loonio Payout
Create a interac Payout
Response
Do sync
Response
We will get pending status, as per doc in sbx we can not fullfill the payouts.
Checklist
cargo +nightly fmt --allcargo clippy