feat(framework): Added diff-checker required code and running ucs in shadow mode#9684
Merged
bernard-eugine merged 27 commits intomainfrom Oct 10, 2025
Merged
feat(framework): Added diff-checker required code and running ucs in shadow mode#9684bernard-eugine merged 27 commits intomainfrom
bernard-eugine merged 27 commits intomainfrom
Conversation
su-shivanshmathur
requested changes
Oct 6, 2025
| merchant_reference_id: Option<ucs_types::UcsReferenceId>, | ||
|
|
||
| request_id: Option<String>, | ||
| } |
Contributor
There was a problem hiding this comment.
Can we please check with @maverox for the subsequent changes
Closed
2 tasks
jarnura
requested changes
Oct 7, 2025
jarnura
requested changes
Oct 10, 2025
| mut client_builder: reqwest::ClientBuilder, | ||
| proxy_config: &Proxy, | ||
| ) -> reqwest::ClientBuilder { | ||
| if let Some(mitm_ca_cert) = &proxy_config.mitm_ca_certificate { |
Member
There was a problem hiding this comment.
if should have else block, avoid writing code without else block
| pub struct ComparisonServiceConfig { | ||
| pub url: Url, | ||
| pub enabled: bool, | ||
| pub timeout_secs: Option<u64>, |
Member
There was a problem hiding this comment.
This can be non optional value with default when value is not passed?
jarnura
approved these changes
Oct 10, 2025
su-shivanshmathur
approved these changes
Oct 10, 2025
chaitak-gorai
pushed a commit
that referenced
this pull request
Oct 16, 2025
…shadow mode (#9684) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
drdholu
pushed a commit
to drdholu/hyperswitch
that referenced
this pull request
Oct 30, 2025
…shadow mode (juspay#9684) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
aadityaguptaa
pushed a commit
that referenced
this pull request
Nov 10, 2025
…shadow mode (#9684) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added a fork using tokio::spawn and sent the cloned router data to UCS,
Added some headers for identification of connector, flow, req-id
called the validation service to send both router data for comparison.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy