Skip to content

feat(connector): [ACI] cypress added#9502

Merged
likhinbopanna merged 4 commits intomainfrom
aci-cypress
Sep 29, 2025
Merged

feat(connector): [ACI] cypress added#9502
likhinbopanna merged 4 commits intomainfrom
aci-cypress

Conversation

@swetasharma03
Copy link
Contributor

@swetasharma03 swetasharma03 commented Sep 23, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added cypress for ACI.

Following bugs were detected while adding cypress, this PR includes the fix for those as well:

  1. card_network is required field only for network_token and not for normal card_payment, so made the field optional and populated missing error only for network_token flow.
  2. When clicked technical_error after redirection, on returning back server was throwing 500 because the code for technical_error was not included in aci/aci_result_codes.rs.
  3. Some fields are optional in capture response, handled it by making them optional.
  4. For Void flow, separate try_from was not there previously and one for Capture was getting used up. This was causing incorrect status mapping for Void.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2025-09-23 at 6 07 35 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@swetasharma03 swetasharma03 self-assigned this Sep 23, 2025
@swetasharma03 swetasharma03 requested review from a team as code owners September 23, 2025 06:29
@semanticdiff-com
Copy link

semanticdiff-com bot commented Sep 23, 2025

@swetasharma03 swetasharma03 changed the title feat(connector): aci cypress added feat(connector): [ACI] cypress added Sep 23, 2025
@swetasharma03 swetasharma03 force-pushed the aci-cypress branch 2 times, most recently from 91f7906 to e660957 Compare September 23, 2025 12:31
ndc: Secret<String>,
}

fn map_aci_void_status(item: AciCaptureStatus) -> enums::AttemptStatus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename AciCaptureStatus to AciStatus

@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit 1c52f69 Sep 29, 2025
21 of 25 checks passed
@likhinbopanna likhinbopanna deleted the aci-cypress branch September 29, 2025 09:09
pixincreate added a commit that referenced this pull request Sep 30, 2025
…pay-new-field

* 'main' of github.com:juspay/hyperswitch: (21 commits)
  feat(payments): add tokenization action handling to payment flow for braintree (#9506)
  feat(connector): [Loonio] Add template code (#9586)
  fix(connector): [paysafe] make `eci_indicator` field optional (#9591)
  fix(core): add should_call_connector_customer function to connector specification (#9569)
  feat(ucs): Add profile ID to lineage tracking in Unified Connector Service (#9559)
  feat(core): Add support for partial auth in proxy payments [V2] (#9503)
  chore(version): 2025.09.30.0
  fix(authorizedotnet): refund via ucs missing connector_metadata (#9581)
  feat(auth): add new authentication to communicate between microservices (#9547)
  Fix: Ideal Giropay Country Currency Config (#9552)
  feat(connector): [ACI] cypress added (#9502)
  feat(connector): Add Peachpayments Cypress (#9573)
  chore(version): 2025.09.29.0
  feat(finix): template code (#9557)
  feat(cypress): add cypress test-cases for manual retry (#9505)
  feat(core): update additional payment method data in psync response (#9519)
  feat(connector): [Checkout] Add Google Pay Predecrypt Flow (#9130)
  feat(framework): Added smithy, smithy-core and smithy-generator crates (#9249)
  fix(core): add request_extended_authorization in the payment attempt and populate it in the payment response (#9492)
  chore(version): 2025.09.26.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ACI connector, Capture (CP) returns "Something went wrong" "HE_00" but CP is successful at ACI

4 participants