feat(router): Add support for updating wallet pm_data to PM update API by AnuthaDev · Pull Request #9388 · juspay/hyperswitch

AnuthaDev · 2025-09-15T12:33:37Z

Type of Change

Description

Added support for updating payment_method_data in case the payment_method_type is wallet.
Added new response type: CustomerPaymentMethodUpdateResponse to include the wallet details being updated in response

For wallets the following fields can be updated:

last4
card_network
type

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

Closes #9387

How did you test it?

Request:

curl --location 'http://localhost:8080/payment_methods/pm_FiEUWFVVyrcdp6o2NW4T/update' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_x85W6hQprLRMbeArLC7rFicIiZRBWelCJCNV8a4Lf2kq2tgCfoHw9LvMRrQ4tn8D' \
--data '{
  "wallet": {
    "last4": "1024",
    "card_network": "Visa",
    "type": "credit"
  }
}'

Response:

{
    "merchant_id": "merchant_1759320450",
    "customer_id": "customer123",
    "payment_method_id": "pm_FiEUWFVVyrcdp6o2NW4T",
    "payment_method": "wallet",
    "payment_method_type": "apple_pay",
    "card": null,
    "wallet": {
      "last4": "1024",
      "card_network": "Visa",
      "type": "credit"
    }
    "recurring_enabled": false,
    "installment_payment_enabled": false,
    "payment_experience": [
        "redirect_to_url"
    ],
    "metadata": null,
    "created": "2025-10-01T12:10:05.824Z",
    "last_used_at": "2025-10-06T08:37:30.787Z",
    "client_secret": "pm_FiEUWFVVyrcdp6o2NW4T_secret_9o1ejWTPIzRzn4WdfoGm"
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-09-15T12:33:40Z

Review changes with

Changed Files

File	Status
crates/router/src/types/api/payment_methods.rs	81% smaller
crates/api_models/src/events/payment.rs	26% smaller
crates/router/src/core/payment_methods/cards.rs	16% smaller
crates/openapi/src/openapi.rs	7% smaller
api-reference/v1/openapi_spec_v1.json	0% smaller
crates/api_models/src/payment_methods.rs	0% smaller

crates/router/src/core/payment_methods/cards.rs

kashif-m · 2025-09-17T06:46:33Z

crates/router/src/core/payment_methods/cards.rs

+            .await
+            .change_context(errors::ApiErrorResponse::InternalServerError)
+            .attach_printable("Failed to update payment method in db")?;
+


Can all the changes be accommodated in a single update DB call?

Trying to have a single DB call for both card and wallet branches leads to convoluted code for response generation. It is cleaner to have 2 DB calls, contained within their branches.

You can return storage::PaymentMethodUpdate from each of the branches and call update_payment_method once.

kashif-m

Added minor comments around refactoring the flow

crates/router/src/core/payment_methods/cards.rs

codecov · 2025-10-27T06:45:35Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8a705fd). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
crates/api_models/src/events/payment.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9388   +/-   ##
=======================================
  Coverage        ?    3.92%           
=======================================
  Files           ?     1223           
  Lines           ?   300980           
  Branches        ?        0           
=======================================
  Hits            ?    11803           
  Misses          ?   289177           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kashif-m · 2025-10-27T06:56:09Z

crates/router/src/core/payment_methods/cards.rs

+    let pm = db
+        .find_payment_method(
+            &((&state).into()),
+            merchant_context.get_merchant_key_store(),
+            payment_method_id,
+            merchant_context.get_merchant_account().storage_scheme,
+        )
+        .await
+        .to_not_found_response(errors::ApiErrorResponse::PaymentMethodNotFound)?;


nit: we can fetch this after validating the client secret?

kashif-m · 2025-10-27T07:01:55Z

crates/router/src/core/payment_methods/cards.rs

+            .into());
+        }
+
+        let updated_pmd = PaymentMethodsData::WalletDetails(wallet_update);


Suggestion:

Can we handle this similarly to how it's handled for cards [ref]

We should be able to update individual fields for wallet data (last4, card_type)

crates/api_models/src/payment_methods.rs

hrithikesh026 · 2025-10-31T04:07:48Z

crates/api_models/src/payment_methods.rs

@@ -481,6 +481,9 @@ pub struct PaymentMethodUpdate {
    "card_holder_name": "John Doe"}))]
    pub card: Option<CardDetailUpdate>,


PaymentMethodUpdate should be an enum. We shouldn't allow passing both card and wallet fields during update right?

crates/router/src/core/payment_methods/cards.rs

#9388)

feat(router): Add support for updating wallet pm_data to PM update API

f3b16de

AnuthaDev self-assigned this Sep 15, 2025

AnuthaDev requested a review from a team as a code owner September 15, 2025 12:33

AnuthaDev added the enhancement New feature or request label Sep 15, 2025

hrithikesh026 reviewed Sep 16, 2025

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Show resolved Hide resolved

hrithikesh026 reviewed Sep 16, 2025

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved

hrithikesh026 reviewed Sep 16, 2025

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved

AnuthaDev added 2 commits September 16, 2025 16:55

Fix CI

fa866ce

Address review comments

dd60fbc

kashif-m reviewed Sep 17, 2025

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved

kashif-m reviewed Sep 17, 2025

View reviewed changes

kashif-m requested changes Sep 17, 2025

View reviewed changes

Address review comments

5d0b6dc

AnuthaDev requested a review from a team as a code owner September 17, 2025 07:30

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 17, 2025

kashif-m previously approved these changes Sep 22, 2025

View reviewed changes

kashif-m reviewed Sep 22, 2025

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Show resolved Hide resolved

su-shivanshmathur previously approved these changes Oct 6, 2025

View reviewed changes

AnuthaDev added 2 commits October 27, 2025 11:42

Merge branch 'main' into pm-update-api-wallet

59685e4

Show updated wallet fields in response

7f6d03b

AnuthaDev dismissed stale reviews from su-shivanshmathur and kashif-m via 7f6d03b October 27, 2025 06:30

Fix clippy

a1b3e6d

AnuthaDev requested a review from a team as a code owner October 27, 2025 06:49

kashif-m previously approved these changes Oct 27, 2025

View reviewed changes

Fix clippy

3555ab9

AnuthaDev dismissed kashif-m’s stale review via 3555ab9 October 30, 2025 07:35

kashif-m approved these changes Oct 30, 2025

View reviewed changes

hrithikesh026 reviewed Oct 31, 2025

View reviewed changes

crates/api_models/src/payment_methods.rs Show resolved Hide resolved

hrithikesh026 reviewed Oct 31, 2025

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Show resolved Hide resolved

hrithikesh026 approved these changes Oct 31, 2025

View reviewed changes

su-shivanshmathur approved these changes Oct 31, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Nov 3, 2025

Merged via the queue into main with commit 2c3fa82 Nov 3, 2025
28 of 32 checks passed

likhinbopanna deleted the pm-update-api-wallet branch November 3, 2025 08:30

AnuthaDev added a commit that referenced this pull request Nov 4, 2025

feat(router): Add support for updating wallet pm_data to PM update API (

492c71e

#9388)

AnuthaDev mentioned this pull request Nov 4, 2025

feat(router): Add support for updating wallet pm_data to PM update API #10117

Closed

14 tasks

AnuthaDev added a commit that referenced this pull request Nov 5, 2025

feat(router): Add support for updating wallet pm_data to PM update API (

cf1f4a2

#9388)

aadityaguptaa pushed a commit that referenced this pull request Nov 10, 2025

feat(router): Add support for updating wallet pm_data to PM update API (

d5c0ce8

#9388)

		@@ -481,6 +481,9 @@ pub struct PaymentMethodUpdate {
		"card_holder_name": "John Doe"}))]
		pub card: Option<CardDetailUpdate>,

Conversation

AnuthaDev commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kashif-m Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

AnuthaDev Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

hrithikesh026 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

kashif-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kashif-m Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

kashif-m Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hrithikesh026 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AnuthaDev commented Sep 15, 2025 •

edited

Loading

semanticdiff-com bot commented Sep 15, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading