feat: introduce a framework to fetch configs from superposition#9289
Merged
likhinbopanna merged 67 commits intomainfrom Oct 9, 2025
Merged
feat: introduce a framework to fetch configs from superposition#9289likhinbopanna merged 67 commits intomainfrom
likhinbopanna merged 67 commits intomainfrom
Conversation
|
Review changes with Changed Files
|
Member
|
Also, please address the failing CI checks, and update the PR description with testing information and relevant screenshots (if applicable). |
crates/router/src/core/configs.rs
Outdated
| default_value: bool, | ||
| ) -> CustomResult<bool, errors::StorageError> { | ||
| // Try superposition first if available | ||
| let mut superposition_result = None; |
Contributor
There was a problem hiding this comment.
we should try to avoid mutable values as much as possible
sai-harsha-vardhan
previously approved these changes
Oct 8, 2025
sai-harsha-vardhan
approved these changes
Oct 8, 2025
SanchithHegde
approved these changes
Oct 8, 2025
jagan-jaya
approved these changes
Oct 8, 2025
chaitak-gorai
pushed a commit
that referenced
this pull request
Oct 16, 2025
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com> Co-authored-by: Sanchith Hegde <sanchith.hegde@juspay.in>
drdholu
pushed a commit
to drdholu/hyperswitch
that referenced
this pull request
Oct 30, 2025
…ay#9289) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com> Co-authored-by: Sanchith Hegde <sanchith.hegde@juspay.in>
aadityaguptaa
pushed a commit
that referenced
this pull request
Nov 10, 2025
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com> Co-authored-by: Sanchith Hegde <sanchith.hegde@juspay.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adding Superposition as an independent module in External Services to abstract the complexity of integrating it with the core application.
Additional Changes
Motivation and Context
Updating the config fetch logic from db to superposition may introduce complexity and the need for developers to have context about superposition. This implementation abstracts the complexity and exposes generic methods to fetch configs from superposition.
How did you test it?
cargo run --features superposition --bin router -- -f ./config/docker_compose.tomlrequires_cvv=trueinsuperpositiondashboard:Checklist
cargo +nightly fmt --allcargo clippy