feat(injector): add support for new crate - injector for external vault proxy#8959
Merged
bernard-eugine merged 88 commits intomainfrom Aug 25, 2025
Merged
feat(injector): add support for new crate - injector for external vault proxy#8959bernard-eugine merged 88 commits intomainfrom
bernard-eugine merged 88 commits intomainfrom
Conversation
|
Review changes with Changed Files
|
2 tasks
…ch into addition_injector_crate
…ch into addition_injector_crate
…ch into addition_injector_crate
…ch into addition_injector_crate
…ch into addition_injector_crate
…ch into addition_injector_crate
…ch into addition_injector_crate
prasunna09
requested changes
Aug 22, 2025
Comment on lines
+924
to
+936
|
|
||
| // #[cfg(feature = "v2")] | ||
| // fn generate_connector_request_reference_id( | ||
| // &self, | ||
| // payment_intent: &hyperswitch_domain_models::payments::PaymentIntent, | ||
| // _payment_attempt: &hyperswitch_domain_models::payments::payment_attempt::PaymentAttempt, | ||
| // ) -> String { | ||
| // payment_intent | ||
| // .merchant_reference_id | ||
| // .as_ref() | ||
| // .map(|id| id.get_string_repr().to_owned()) | ||
| // .unwrap_or_else(|| connector_utils::generate_12_digit_number().to_string()) | ||
| // } |
Contributor
There was a problem hiding this comment.
please revert this change. seems like this is irrelevant change
| } | ||
|
|
||
| #[cfg(not(feature = "v2"))] | ||
| #[cfg(feature = "v1")] |
Contributor
There was a problem hiding this comment.
if not required, please revert this
crates/injector/src/injector.rs
Outdated
| let tokens = find_all_tokens(&template); | ||
| let mut result = template; | ||
|
|
||
| for token_ref in tokens { |
…ch into addition_injector_crate
…ch into addition_injector_crate
prasunna09
reviewed
Aug 25, 2025
Comment on lines
+14
to
+20
| pub enum ContentType { | ||
| ApplicationJson, | ||
| ApplicationXWwwFormUrlencoded, | ||
| ApplicationXml, | ||
| TextXml, | ||
| TextPlain, | ||
| } |
Contributor
There was a problem hiding this comment.
good that we moved to this crate.
cargo hack has been failing due to this particular structure is in hyperswitch interfaces which indirectly uses domain models and others.
but what of maintenance part? for the similar structures as well?
ps. not a blocker currently
CC: @jarnura
crates/injector/src/injector.rs
Outdated
Comment on lines
+403
to
+409
| let method = match config.http_method { | ||
| injector_types::HttpMethod::GET => Method::Get, | ||
| injector_types::HttpMethod::POST => Method::Post, | ||
| injector_types::HttpMethod::PUT => Method::Put, | ||
| injector_types::HttpMethod::PATCH => Method::Patch, | ||
| injector_types::HttpMethod::DELETE => Method::Delete, | ||
| }; |
Contributor
There was a problem hiding this comment.
we can write a from impl for this
crates/injector/src/injector.rs
Outdated
Comment on lines
+518
to
+523
| if response_text.len() > 10_000_000 { | ||
| // 10MB limit | ||
| logger::error!( | ||
| response_length = response_text.len(), | ||
| "Response from connector is too large, potential DoS or memory exhaustion" | ||
| ); |
Contributor
There was a problem hiding this comment.
why are we checking the response length? do we do this for normal connector call as well??
prasunna09
approved these changes
Aug 25, 2025
Comment on lines
+94
to
+100
| let method = match request.method { | ||
| Method::Get => reqwest::Method::GET, | ||
| Method::Post => reqwest::Method::POST, | ||
| Method::Put => reqwest::Method::PUT, | ||
| Method::Patch => reqwest::Method::PATCH, | ||
| Method::Delete => reqwest::Method::DELETE, | ||
| }; |
| req_builder = req_builder.body(payload); | ||
| } | ||
| _ => { | ||
| logger::warn!("Unsupported request content type, using raw bytes"); |
Contributor
There was a problem hiding this comment.
throw an error instead of warning
| } | ||
|
|
||
| #[derive(Error, Debug)] | ||
| pub enum InjectorError { |
Contributor
There was a problem hiding this comment.
Ideally this HttpRequestFailed should be API error, and injector errors are different which would include TokenReplacementFailed.
Comment on lines
+440
to
+445
| ContentType::ApplicationXml | ContentType::TextXml => { | ||
| Some(RequestContent::RawBytes(payload.as_bytes().to_vec())) | ||
| } | ||
| ContentType::TextPlain => { | ||
| Some(RequestContent::RawBytes(payload.as_bytes().to_vec())) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| ContentType::ApplicationXml | ContentType::TextXml => { | |
| Some(RequestContent::RawBytes(payload.as_bytes().to_vec())) | |
| } | |
| ContentType::TextPlain => { | |
| Some(RequestContent::RawBytes(payload.as_bytes().to_vec())) | |
| } | |
| ContentType::ApplicationXml | ContentType::TextXml | | |
| ContentType::TextPlain => { | |
| Some(RequestContent::RawBytes(payload.as_bytes().to_vec())) | |
| } |
jarnura
approved these changes
Aug 25, 2025
Pradesh-S
pushed a commit
that referenced
this pull request
Aug 26, 2025
…lt proxy (#8959) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This is the injector crate which would be used for External Vault proxy usage
Additional Changes
Motivation and Context
Needed a generic way of passing on text as card number which would be swaped on vaults's end for not having PCI compliant data in router.
How did you test it?
Have added a test case in the crate itself
Checklist
cargo +nightly fmt --allcargo clippy