refactor(cypress): update skip logic and test flow for cypress incremental auth tests by arindam-sahoo · Pull Request #8594 · juspay/hyperswitch

arindam-sahoo · 2025-07-09T17:08:39Z

Type of Change

Description

This PR introduces a set of improvements and refactors in the Cypress test suite specifically for Incremental Authorization test cases.

✅ Key Changes:

Connector Inclusion List for Incremental Auth
- Introduced a new list INCREMENTAL_AUTH in Utils.js under CONNECTOR_LISTS.INCLUDE.
- This inclusion list determines which connectors support Incremental Authorization and should execute related tests.
Dynamic Skipping of Tests Based on Connector Support
- Refactored the test flow to dynamically skip() test blocks at runtime if the connector isn't included in INCREMENTAL_AUTH.
- Prevents false negatives and unwanted test runs on unsupported connectors (like CyberSource with known MULTIPLE_CONNECTORS issues).
Refactored before and after Hooks
- Replaced arrow functions with regular functions in before() hooks to correctly utilize this.skip().
- Ensured proper state flushing with afterEach instead of after.
Improved Capture Test for Incremental Auth
- Modified the capture test logic to simulate an incremented capture amount.
- Prevents test result from falling into partially_captured due to stale previously_authorized_amount.
Enhanced Assertions for Incremental Auth Response
- Added deep assertions for previously_authorized_amount from incremental_authorizations to validate correctness of incremental logic.
- Ensures the captured amount matches the expected post-incremented value.

🧪 Test Impact:

Only connectors in INCREMENTAL_AUTH list will now run Incremental Authorization tests.
Currently includes: cybersource (commented out due to known issue), paypal, and archipel (handled in related PR ci(cypress): fix archipel cypress test cases #8189).
Other connectors will auto-skip these tests, improving CI stability and relevance.

💡 Reference

Followed the pattern used in working test files like 00020-MandatesUsingNTIDProxy.cy.js, which implement this.skip() with proper connector inclusion checks.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

The test suite for Incremental Auth (00029-IncrementalAuth.cy.js) was being entirely skipped due to usage of describe.skip and context handling.

How did you test it?

Cybersource (Skipped)	ArchiPEL

Sanity

Stripe	Adyen	Bluesnap	Bank of America

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-07-09T17:08:42Z

Review changes with

Changed Files

File	Status
cypress-tests/cypress/support/commands.js	75% smaller
cypress-tests/cypress/e2e/spec/Payment/00029-IncrementalAuth.cy.js	37% smaller
cypress-tests/cypress/e2e/configs/Payment/Cybersource.js	0% smaller
cypress-tests/cypress/e2e/configs/Payment/Utils.js	0% smaller

… Incremental Auth

…/hyperswitch into chore/incremental-auth-cy

…rect response validation

arindam-sahoo · 2025-07-10T03:16:24Z

cypress-tests/cypress/e2e/configs/Payment/Utils.js

  // Inclusion lists (only run for these connectors)
  INCLUDE: {
    MANDATES_USING_NTID_PROXY: ["cybersource"],
+    INCREMENTAL_AUTH: ["cybersource"],


Added INCREMENTAL_AUTH as a new list of connectors that supports Incremental Authorization.

In this PR, I am just creating the include list, so I'm not adding all the supporting connectors, but as of my knowledge, it should be archipel(which is addressed in my next PR #8189 ), cybersource and paypal (which will be merged soon after this PR I guess).

arindam-sahoo · 2025-07-10T03:24:52Z

cypress-tests/cypress/support/commands.js

+            .to.equal(
+              response.body.incremental_authorizations[key]
+                .previously_authorized_amount
+            ).and.not.be.null;


Before After

arindam-sahoo · 2025-07-10T03:26:03Z

cypress-tests/cypress/e2e/spec/Payment/00029-IncrementalAuth.cy.js

-    beforeEach(function () {
-      if (!shouldContinue || connector !== "cybersource") {
-        this.skip();
-      }
-    });


Added the Inclusion List in the Utils.js, so its not needed here.

arindam-sahoo · 2025-07-10T03:38:33Z

cypress-tests/cypress/e2e/spec/Payment/00029-IncrementalAuth.cy.js

+      const newData = {
+        ...data,
+        Request: { amount_to_capture: data.Request.amount_to_capture + 1000 },
+      };
+
+      cy.captureCallTest(fixtures.captureBody, newData, globalState);


It was capturing the previously_authorized_amount, which resulted the terminal payment status to be partially_captured. Therefore, there were two options, either add a custom response assertion in the Capture config of the connector, or just update the value in the cypress test case itself, because it will be only the case for Incremental Auth only. So, found it more relevant to do it over here. However, the increased amount has been hard-coded to 1000.

cypress-tests/cypress/e2e/configs/Payment/Utils.js

arindam-sahoo · 2025-07-10T04:18:17Z

cypress-tests/cypress/e2e/configs/Payment/Utils.js

  // Inclusion lists (only run for these connectors)
  INCLUDE: {
    MANDATES_USING_NTID_PROXY: ["cybersource"],
+    INCREMENTAL_AUTH: [


Added INCREMENTAL_AUTH as a new list of connectors that supports Incremental Authorization.

In this PR, I am just creating the include list, so I'm not adding all the supporting connectors, but as of my knowledge, it should be archipel(which is addressed in my next PR #8189 ), cybersource and paypal (which will be merged soon after this PR I guess).

arindam-sahoo · 2025-07-10T04:19:11Z

cypress-tests/cypress/e2e/configs/Payment/Utils.js

  INCLUDE: {
    MANDATES_USING_NTID_PROXY: ["cybersource"],
+    INCREMENTAL_AUTH: [
+      // "cybersource"    // issues with MULTIPLE_CONNECTORS handling


Currently, I am thinking to comment out cybersource, so that the incremental auth tests skip for it, because it seems there are some issues handling MULTIPLE_CONNECTORS in cybersource, which is resulting in test cases failure for cybersource and hence it will block all the PRs, and prevent them from getting merged.

…n and test

…ayload-webhooks * 'main' of github.com:juspay/hyperswitch: feat(payments): propagate additional payment method data for apple pay during MIT (#7170) feat(core): Hyperswitch <|> UCS integration v2 (#8439) feat(connector): [payload] add webhook support (#8558) ci(cypress): Added Dlocal Connector Test (#8362) feat(connector): [AIRWALLEX] - Added Paypal, Trustly, Klarna , Atome, Blik Payment Methods (#8475) refactor(cypress): update skip logic and test flow for cypress incremental auth tests (#8594) chore(version): 2025.07.11.0 chore: address Rust 1.88.0 clippy lints (#8607) chore(version): 2025.07.10.0

ci(cypress): enable Incremental Auth tests for included connectors

72953f8

arindam-sahoo self-assigned this Jul 9, 2025

arindam-sahoo added the A-CI-CD Area: Continuous Integration/Deployment label Jul 9, 2025

arindam-sahoo added this to the Jul milestone Jul 9, 2025

arindam-sahoo linked an issue Jul 9, 2025 that may be closed by this pull request

fix(cypress): cypress tests for incremental auth getting skipped for all connectors #8595

Closed

arindam-sahoo and others added 4 commits July 9, 2025 22:55

chore(cypress): add continuation flag for Incremental Pre-Auth tests

d5f6ac0

chore(cypress): run formatter and address lints

e22cbc6

chore(ci): update comment to reflect current supported connectors for…

e3aaee9

… Incremental Auth

Merge branch 'chore/incremental-auth-cy' of https://github.com/juspay…

e2dfc9f

…/hyperswitch into chore/incremental-auth-cy

arindam-sahoo marked this pull request as ready for review July 9, 2025 18:33

arindam-sahoo requested a review from a team as a code owner July 9, 2025 18:33

arindam-sahoo and others added 3 commits July 10, 2025 08:28

fix(cypress): update capture amount in Incremental Auth tests and cor…

72779f5

…rect response validation

chore(cypress): run formatter and address lints

241cae3

Merge branch 'main' into chore/incremental-auth-cy

319d781

arindam-sahoo commented Jul 10, 2025

View reviewed changes

cypress-tests/cypress/e2e/configs/Payment/Utils.js Outdated Show resolved Hide resolved

Update cypress-tests/cypress/e2e/configs/Payment/Utils.js

32aea29

arindam-sahoo commented Jul 10, 2025

View reviewed changes

arindam-sahoo requested review from Gnanasundari24, likhinbopanna and pixincreate July 10, 2025 04:20

arindam-sahoo changed the title ~~refactor(cypress): refactor skip logic and test flow for cypress incremental auth tests~~ refactor(cypress): update skip logic and test flow for cypress incremental auth tests Jul 10, 2025

likhinbopanna previously approved these changes Jul 10, 2025

View reviewed changes

Gnanasundari24 previously approved these changes Jul 10, 2025

View reviewed changes

pixincreate previously approved these changes Jul 10, 2025

View reviewed changes

fix(cypress): update Incremental Auth capture amounts in configuratio…

974e991

…n and test

arindam-sahoo dismissed stale reviews from pixincreate and Gnanasundari24 via 974e991 July 10, 2025 07:23

arindam-sahoo dismissed likhinbopanna’s stale review via 974e991 July 10, 2025 07:23

arindam-sahoo requested review from Gnanasundari24, likhinbopanna and pixincreate July 10, 2025 07:35

pixincreate approved these changes Jul 10, 2025

View reviewed changes

Gnanasundari24 approved these changes Jul 10, 2025

View reviewed changes

Gnanasundari24 enabled auto-merge July 10, 2025 11:32

Merge branch 'main' into chore/incremental-auth-cy

36fb014

Gnanasundari24 added this pull request to the merge queue Jul 11, 2025

Merged via the queue into main with commit 3c49871 Jul 11, 2025
14 of 20 checks passed

Gnanasundari24 deleted the chore/incremental-auth-cy branch July 11, 2025 02:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(cypress): update skip logic and test flow for cypress incremental auth tests#8594

refactor(cypress): update skip logic and test flow for cypress incremental auth tests#8594
Gnanasundari24 merged 11 commits intomainfrom
chore/incremental-auth-cy

arindam-sahoo commented Jul 9, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

arindam-sahoo Jul 10, 2025

Uh oh!

arindam-sahoo Jul 10, 2025

Uh oh!

arindam-sahoo Jul 10, 2025

Uh oh!

arindam-sahoo Jul 10, 2025

Uh oh!

Uh oh!

arindam-sahoo Jul 10, 2025

Uh oh!

arindam-sahoo Jul 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

arindam-sahoo commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

✅ Key Changes:

🧪 Test Impact:

💡 Reference

Additional Changes

Motivation and Context

How did you test it?

Sanity

Checklist

Uh oh!

semanticdiff-com bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arindam-sahoo Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

arindam-sahoo Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

arindam-sahoo Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

arindam-sahoo Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arindam-sahoo Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

arindam-sahoo Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arindam-sahoo commented Jul 9, 2025 •

edited

Loading

semanticdiff-com bot commented Jul 9, 2025 •

edited

Loading

arindam-sahoo Jul 10, 2025 •

edited

Loading