Skip to content

feat(router): add confirm flag in kafka payment intent events#8432

Merged
Gnanasundari24 merged 4 commits intomainfrom
send-confirm-flag-in-intent-events
Jun 24, 2025
Merged

feat(router): add confirm flag in kafka payment intent events#8432
Gnanasundari24 merged 4 commits intomainfrom
send-confirm-flag-in-intent-events

Conversation

@sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Jun 23, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add confirm flag in kafka payment intent events

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
confirm flag sent as true in payment intent event in kafka
image

consolidated event
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added this to the June 2025 Release milestone Jun 23, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jun 23, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner June 23, 2025 09:39
@sai-harsha-vardhan sai-harsha-vardhan added the A-framework Area: Framework label Jun 23, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner June 23, 2025 09:39
@sai-harsha-vardhan sai-harsha-vardhan added the A-core Area: Core flows label Jun 23, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Jun 23, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/db/kafka_store.rs  34% smaller
  crates/common_utils/src/types/keymanager.rs  0% smaller
  crates/hyperswitch_domain_models/src/payments/payment_intent.rs  0% smaller
  crates/router/src/core/payments/operations/payment_confirm.rs  0% smaller
  crates/router/src/core/payments/operations/payment_update.rs  0% smaller

@su-shivanshmathur
Copy link
Contributor

su-shivanshmathur commented Jun 24, 2025

Can you please share it for consolidated events as well

@likhinbopanna likhinbopanna enabled auto-merge June 24, 2025 07:59
@Gnanasundari24 Gnanasundari24 disabled auto-merge June 24, 2025 08:06
@Gnanasundari24 Gnanasundari24 enabled auto-merge June 24, 2025 08:06
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit bc767b9 Jun 24, 2025
16 of 20 checks passed
@Gnanasundari24 Gnanasundari24 deleted the send-confirm-flag-in-intent-events branch June 24, 2025 09:09
sai-harsha-vardhan added a commit that referenced this pull request Jun 24, 2025
@sai-harsha-vardhan @hyperswitch-bot
feat(router): add confirm flag in kafka payment intent events (#8432)
9be53bb 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
@sai-harsha-vardhan sai-harsha-vardhan mentioned this pull request Jun 24, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@su-shivanshmathur su-shivanshmathur su-shivanshmathur approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels

A-core Area: Core flows A-framework Area: Framework

Projects

None yet

Milestone

June 2025 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@sai-harsha-vardhan @su-shivanshmathur @ShankarSinghC @Gnanasundari24