Skip to content

fix(router): Fixed stack over flow for session call in authentication connectors#7983

Merged
SanchithHegde merged 1 commit intomainfrom
9447-bug-fix-fix-stack-overflow-for-authentication-connectors-in-session-call
May 8, 2025
Merged

fix(router): Fixed stack over flow for session call in authentication connectors#7983
SanchithHegde merged 1 commit intomainfrom
9447-bug-fix-fix-stack-overflow-for-authentication-connectors-in-session-call

Conversation

@sahkal
Copy link
Contributor

@sahkal sahkal commented May 8, 2025

Type of Change

  • Bugfix

Description

Fixed stack over flow for session call in authentication connectors

Motivation and Context

Currently when we are doing session call for authentication connectors stack is overflowing since the function

list_enabled_connector_accounts_by_profile_id is calling itself recursively in implementation of kafka store.

How did you test it?

Setup Click to Pay and do session call should provide proper response than 503

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sahkal sahkal added this to the May 2025 Release milestone May 8, 2025
@sahkal sahkal self-assigned this May 8, 2025
@sahkal sahkal requested a review from a team as a code owner May 8, 2025 08:53
@sahkal sahkal added the C-bug Category: Bug label May 8, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented May 8, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/db/kafka_store.rs  97% smaller

@SanchithHegde SanchithHegde enabled auto-merge May 8, 2025 08:58
@SanchithHegde SanchithHegde added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 1933722 May 8, 2025
16 of 20 checks passed
@SanchithHegde SanchithHegde deleted the 9447-bug-fix-fix-stack-overflow-for-authentication-connectors-in-session-call branch May 8, 2025 10:10
pixincreate added a commit that referenced this pull request May 12, 2025
…adyen-ideal

* 'main' of github.com:juspay/hyperswitch: (62 commits)
  fix(core): language consumption from locale in payment and payout links (#7993)
  feat(refunds_v2): Add refunds list flow in v2 apis (#7966)
  refactor(connector): [Noon] auth header (#7977)
  fix(connector): [Novalnet] send decoded token for apple pay payment (#7973)
  feat(business_profile): add business_profile config to enable external vault (#7876)
  feat(vsaas): integrate onboarding flow for vertical saas (#7884)
  feat(connector): Introduce connector template code for WorldpayXML  (#7968)
  feat(connector): [ADYEN, CHECKOUT] Added In Feature Matrix API (#7914)
  feat(core): add psync support for recovery external payments (#7855)
  refactor(open_router): call elimination routing of open router if enabled instead of dynamo (#7961)
  feat(payment_methods): add v2 api for fetching token data (#7629)
  ci(cypress): Fix Bank Redirects for stripe test (#8004)
  chore(version): 2025.05.12.0
  refactor(authentication): moved cavv storing from table to temp locker (#7978)
  chore(version): 2025.05.09.0
  feat(connector): [paypal, trustpay] add in feature matrix (#7911)
  fix(update_metadata): Update Metadata for any connectors other than stripe gives 500 error (#7984)
  fix(router): Fixed stack over flow for session call in authentication connectors (#7983)
  chore(version): 2025.05.08.0
  fix(payment): disable payment update via client config (#7970)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants