Skip to content

feat(dashboard_metadata): Add ReconStatus in dashboard_metadata#7595

Merged
likhinbopanna merged 7 commits intomainfrom
recon-done-metadata
Mar 26, 2025
Merged

feat(dashboard_metadata): Add ReconStatus in dashboard_metadata#7595
likhinbopanna merged 7 commits intomainfrom
recon-done-metadata

Conversation

@ThisIsMani
Copy link
Contributor

@ThisIsMani ThisIsMani commented Mar 21, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR will add a new variant in Dashboard Metadata for storing the recon state.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #2647

How did you test it?

curl --location 'http://localhost:8080/user/data' \
--header 'Content-Type: application/json' \
--header 'Authorization: User JWT' \
--data '{
    "ReconStatus": {
        "is_order_data_set": true,
        "is_processor_data_set": true
    }
}'

The above API will give 200 OK.

curl --location 'http://localhost:8080/user/data?keys=ReconStatus' \
--header 'Authorization: User JWT'

Response:

{
    "ReconStatus": {
        "is_order_data_set": true,
        "is_processor_data_set": true
    }
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ThisIsMani ThisIsMani added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-users Area: Users labels Mar 21, 2025
@ThisIsMani ThisIsMani self-assigned this Mar 21, 2025
@ThisIsMani ThisIsMani requested review from a team as code owners March 21, 2025 11:55
@semanticdiff-com
Copy link

semanticdiff-com bot commented Mar 21, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/utils/user/dashboard_metadata.rs  89% smaller
  crates/api_models/src/user/dashboard_metadata.rs  0% smaller
  crates/diesel_models/src/enums.rs  0% smaller
  crates/router/src/core/user/dashboard_metadata.rs  0% smaller
  crates/router/src/types/domain/user/dashboard_metadata.rs  0% smaller
  migrations/2025-03-21-113624_add-recon-status-enum-variant-dashboard-metadata/down.sql Unsupported file format
  migrations/2025-03-21-113624_add-recon-status-enum-variant-dashboard-metadata/up.sql Unsupported file format

apoorvdixit88
apoorvdixit88 previously approved these changes Mar 21, 2025
View reviewed changes
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Mar 21, 2025
SanchithHegde
SanchithHegde reviewed Mar 23, 2025
View reviewed changes
crates/api_models/src/user/dashboard_metadata.rs
Comment on lines +108 to +109
#[derive(Debug, serde::Deserialize, serde::Serialize, Clone)]
pub struct ReconStatus {
Copy link
Member

@SanchithHegde SanchithHegde Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This can also derive Copy for now (because all fields are bools).

Optional change, by the way.

crates/router/src/core/user/dashboard_metadata.rs Outdated
data,
)
.await
.change_context(UserErrors::InternalServerError);
Copy link
Member

@SanchithHegde SanchithHegde Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add context message.

Copy link
Contributor Author

@ThisIsMani ThisIsMani Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the change context here. Added a context message in the inner function call.

@likhinbopanna likhinbopanna added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 7b275ec Mar 26, 2025
17 of 20 checks passed
@likhinbopanna likhinbopanna deleted the recon-done-metadata branch March 26, 2025 10:26
pixincreate added a commit that referenced this pull request Mar 26, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into connector/f…
077f18b 
…acilitapay

* 'main' of github.com:juspay/hyperswitch:
  chore(cypress): bump cypress to `v14.2.0` (#7640)
  feat(connector): [BRAINTREE] Pass connector request reference id (#7609)
  fix(connector): [GlobalPay] Address `5xx` when cancelling a paypal transaction (#7605)
  feat(dashboard_metadata): Add `ReconStatus` in `dashboard_metadata` (#7595)
  fix(connectors): [Adyen] remove redundant enums  (#7601)
  feat: add routing support for v2 sdk session flow (#6763)
  chore(version): 2025.03.26.0
  feat(connector): [Coingate] add wasm changes for coingate metadata (#7632)
  feat(connector): [TRUSTPAY]  implement Banktransfer PaymentMethod (#7575)
  feat(connector): [BANKOFAMERICA] Implement Samsung Pay (#6888)
  fix(connector):  add Nomupay in payout_connector_list for all environment (#7521)
  chore(version): 2025.03.25.0
pixincreate added a commit that referenced this pull request Mar 27, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into ci/pm_activ…
f50ffab 
…e-status-check

* 'main' of github.com:juspay/hyperswitch:
  build(docker): specify user for runner stage (#7641)
  chore(version): 2025.03.27.0
  fix(connector): [Nexixpay] update status mapping nexixpay (#7612)
  refactor(connector): [TrustPay] Fix status and wasm changes  (#7649)
  fix(connector): [redsys] psync transaction type mapping (#7628)
  feat(themes): Add email configuration support for themes (#7580)
  feat(core): add profile level config for debit routing feature (#7470)
  fix(connector): [CYBERSOURCE]  change ucaf_collection_indicator for mastercard payments via netcetera (#7623)
  fix(connector): fix required fields for mandates supported connectors (#6930)
  chore(cypress): bump cypress to `v14.2.0` (#7640)
  feat(connector): [BRAINTREE] Pass connector request reference id (#7609)
  fix(connector): [GlobalPay] Address `5xx` when cancelling a paypal transaction (#7605)
  feat(dashboard_metadata): Add `ReconStatus` in `dashboard_metadata` (#7595)
  fix(connectors): [Adyen] remove redundant enums  (#7601)
  feat: add routing support for v2 sdk session flow (#6763)
@hyperswitch-bot hyperswitch-bot bot removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@apoorvdixit88 apoorvdixit88 apoorvdixit88 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 left review comments

@racnan racnan Awaiting requested review from racnan

Assignees

@ThisIsMani ThisIsMani

Labels

A-users Area: Users C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(dashboard_metadata): Ability to store the state of the Recon for merchant

6 participants

@ThisIsMani @SanchithHegde @Riddhiagrawal001 @apoorvdixit88 @JeevaRamu0104 @likhinbopanna