feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields by sai-harsha-vardhan · Pull Request #7429 · juspay/hyperswitch

sai-harsha-vardhan · 2025-03-04T15:12:31Z

Type of Change

Description

add capability to force challenge for 3DS Payments through Netcetera and send few optional fields

Profile level enablement force_3ds_challenge which would request netcetera for challenge flow
Send few optional fields like trans_type, which can potentially be required on PROD (Because docs says, it maybe required in some markets)

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
Perform a External 3DS payment by enabling force_3ds_challenge at profile level, and observe ThreeDSRequestorChallengeInd being sent "04" to netcetera connector

CURL

curl --location '{{BASE_URL}}/payments/{{PAYMENT_ID}}/3ds/authentication' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: {{PUBLISHABLE_KEY}}' \
--data '{
    "client_secret": "pay_SiyzAZBqOJgLShX0Kjxw_secret_vEfMKRmj8ovnvxVYJdqK",
    "device_channel": "BRW",
    "threeds_method_comp_ind": "Y"
}'

Response

{
    "trans_status": "C",
    "acs_url": "https://ndm-prev.3dss-non-prod.cloud.netcetera.com/acs/challenge",
    "challenge_request": "eyJtZXNzYWdlVHlwZSI6IkNSZXEiLCJ0aHJlZURTU2VydmVyVHJhbnNJRCI6IjRjY2M5ZGRkLWMxZGMtNGMyNy04YzAyLTg5NmE2MzI5MWMzZCIsImFjc1RyYW5zSUQiOiI5MWM0MWZjOS0zZDI1LTQ0OGItODA4MS1mMDkxOTg3NmM1ZTQiLCJjaGFsbGVuZ2VXaW5kb3dTaXplIjoiMDUiLCJtZXNzYWdlVmVyc2lvbiI6IjIuMy4xIn0",
    "acs_reference_number": "3DS_LOA_ACS_201_13579",
    "acs_trans_id": "91c41fc9-3d25-448b-8081-f0919876c5e4",
    "three_dsserver_trans_id": "4ccc9ddd-c1dc-4c27-8c02-896a63291c3d",
    "acs_signed_content": null,
    "three_ds_requestor_url": "https://google.com/"
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-03-04T15:12:33Z

Review changes with

Changed Files

File	Status
crates/router/src/connector/netcetera/netcetera_types.rs	42% smaller
crates/router/src/connector/netcetera/transformers.rs	21% smaller
crates/api_models/src/admin.rs	0% smaller
crates/common_utils/src/types.rs	0% smaller
crates/diesel_models/src/business_profile.rs	0% smaller
crates/diesel_models/src/schema.rs	0% smaller
crates/diesel_models/src/schema_v2.rs	0% smaller
crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs	0% smaller
crates/hyperswitch_domain_models/src/business_profile.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types/authentication.rs	0% smaller
crates/router/src/core/admin.rs	0% smaller
crates/router/src/core/authentication.rs	0% smaller
crates/router/src/core/authentication/transformers.rs	0% smaller
crates/router/src/core/payments.rs	0% smaller
crates/router/src/types/api/admin.rs	0% smaller
migrations/2025-03-04-105454_add_force_3ds_challenge_column_to_business_profile/down.sql	Unsupported file format
migrations/2025-03-04-105454_add_force_3ds_challenge_column_to_business_profile/up.sql	Unsupported file format

ShankarSinghC · 2025-03-05T14:21:05Z

crates/common_utils/src/types.rs

        self.0.major
    }
+
+    /// returns major version number


Suggested change

/// returns major version number

/// returns minor version number

ShankarSinghC · 2025-03-05T14:25:40Z

crates/api_models/src/admin.rs

    pub is_clear_pan_retries_enabled: Option<bool>,
+
+    /// Indicates if 3ds challenge is forced
+    pub force_3ds_challenge: Option<bool>,


Instead of optional, can we have this as bool only and make is false by default ?

ShankarSinghC · 2025-03-05T14:26:52Z

crates/hyperswitch_domain_models/src/business_profile.rs

    pub card_testing_guard_config: Option<CardTestingGuardConfig>,
    pub card_testing_secret_key: OptionalEncryptableName,
    pub is_clear_pan_retries_enabled: bool,
+    pub force_3ds_challenge: Option<bool>,


ShankarSinghC · 2025-03-05T14:34:03Z

migrations/2025-03-04-105454_add_force_3ds_challenge_column_to_business_profile/up.sql

@@ -0,0 +1,2 @@
+ALTER TABLE business_profile


Query will also change if you are making it a mandatory field.

…ugh Netcetera and send few optional fields (#7429) Co-authored-by: Sk Sakil Mostak <skmahim71@gmail.com> Co-authored-by: Sakil Mostak <73734619+Sakilmostak@users.noreply.github.com>

* 'main' of github.com:juspay/hyperswitch: feat(hipay): Add Template PR (#7360) chore(version): 2025.03.07.0 chore(postman): update Postman collection files feat(analytics): add new filters, dimensions and metrics for authentication analytics (#7451) feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields (#7429) feat(analytics): refactor and rewrite authentication related analytics (#7433) refactor(core): Added payment id in authentication router data (#7441) feat(connector): Added ThreeDs server integration template pr (#7424) fix(xendit): Fix wasm changes (#7419) chore(postman): postman tests fixes (#7159) ci(cypress): move customer acceptance in configs to a const within commons (#7435) feat(core): add additional revenue recovery call flow (#7402) chore(version): 2025.03.06.0 feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427)

…juspay/hyperswitch into connector/gpay-mandates-authorizedotnet * 'connector/gpay-mandates-authorizedotnet' of github.com:juspay/hyperswitch: (25 commits) ci(cypress): address lints and refactor redirection handler (#7437) chore: make v1 merchant account forward compatible (#7426) fix(dashboard): Added auth key to juspay threeds server (#7457) feat(hipay): Add Template PR (#7360) chore(version): 2025.03.07.0 chore(postman): update Postman collection files feat(analytics): add new filters, dimensions and metrics for authentication analytics (#7451) feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields (#7429) feat(analytics): refactor and rewrite authentication related analytics (#7433) refactor(core): Added payment id in authentication router data (#7441) feat(connector): Added ThreeDs server integration template pr (#7424) fix(xendit): Fix wasm changes (#7419) chore(postman): postman tests fixes (#7159) ci(cypress): move customer acceptance in configs to a const within commons (#7435) feat(core): add additional revenue recovery call flow (#7402) chore(version): 2025.03.06.0 feat(payment_link): expose payment link configs for SDK UI rules and payment button (#7427) feat(connector): [EFT] Add EFT as a payment method (#7304) chore(version): 2025.03.05.1 feat(connector): [Moneris] Implement mandate for Moneris (#7322) ...

sai-harsha-vardhan and others added 3 commits March 4, 2025 15:51

send necessary fields to netcetera during authentication request

c740ce7

feat: add force_3ds_challenge field to business profile

46fa93f

refactor: set vector based on message version

db57b15

sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement labels Mar 4, 2025

sai-harsha-vardhan added this to the February 2025 Release milestone Mar 4, 2025

sai-harsha-vardhan self-assigned this Mar 4, 2025

sai-harsha-vardhan requested review from a team as code owners March 4, 2025 15:12

hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Mar 4, 2025

sai-harsha-vardhan changed the title ~~Force 3ds challenge refactor netcetera~~ feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields Mar 4, 2025

sai-harsha-vardhan added 2 commits March 4, 2025 20:59

resolve conflicts

cffe064

send eci_raw to cybersource during external authentication flow

758d5d0

Sakilmostak mentioned this pull request Mar 5, 2025

feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields #7434

Merged

14 tasks

swangi-kumari previously approved these changes Mar 5, 2025

View reviewed changes

ShankarSinghC reviewed Mar 5, 2025

View reviewed changes

refactor: resolve comments

567088e

Sakilmostak dismissed swangi-kumari’s stale review via 567088e March 6, 2025 10:23

Sakilmostak and others added 3 commits March 6, 2025 16:26

refactor: resolve comments

ca32a4f

Merge branch 'main' into force-3ds-challenge-refactor-netcetera

df4688c

Merge branch 'main' into force-3ds-challenge-refactor-netcetera

1515e5e

ShankarSinghC approved these changes Mar 6, 2025

View reviewed changes

swangi-kumari approved these changes Mar 6, 2025

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Mar 6, 2025

Merged via the queue into main with commit 957a228 Mar 6, 2025
14 of 20 checks passed

Gnanasundari24 deleted the force-3ds-challenge-refactor-netcetera branch March 6, 2025 13:37

Sakilmostak mentioned this pull request Mar 6, 2025

feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields #7449

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields#7429

feat(router): add capability to force challenge for 3DS Payments through Netcetera and send few optional fields#7429
Gnanasundari24 merged 9 commits intomainfrom
force-3ds-challenge-refactor-netcetera

sai-harsha-vardhan commented Mar 4, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Mar 4, 2025 •

edited

Loading

Uh oh!

ShankarSinghC Mar 5, 2025

Uh oh!

ShankarSinghC Mar 5, 2025

Uh oh!

ShankarSinghC Mar 5, 2025

Uh oh!

ShankarSinghC Mar 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	/// returns major version number
	/// returns minor version number

Conversation

sai-harsha-vardhan commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShankarSinghC Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

ShankarSinghC Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

ShankarSinghC Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

ShankarSinghC Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sai-harsha-vardhan commented Mar 4, 2025 •

edited

Loading

semanticdiff-com bot commented Mar 4, 2025 •

edited

Loading