fix(router): [Cybersource] add flag to indicate final capture by AkshayaFoiger · Pull Request #7085 · juspay/hyperswitch

AkshayaFoiger · 2025-01-22T06:07:19Z

Type of Change

Description

Added flag to the CyberSource capture call to indicate the final capture in cases of manual capture.
This flag has been incorporated into the CyberSource capture request body to ensure the issuer bank is informed appropriately.

How did you test it?

Create a payment with cybersource

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key:*******' \
--data-raw '{
    "amount": 1000,
    "currency": "USD",
    "confirm": true,
    "capture_method": "manual",
    "customer_id": "cust_no_pm",
    "authentication_type": "no_three_ds",   
    "email": "guest@example.com",
    "payment_method": "card",
    "payment_method_type": "debit",
    "payment_method_data": {
        "card": {
            "card_number": "4917 6100 0000 0000", 
            "card_exp_month": "03",
            "card_exp_year": "30",
            "card_holder_name": "joseph Doe",
            "card_cvc": "737"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    }, 
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "13.232.74.226"
    }
  
}'

Response

{
    "payment_id": "pay_lNsJx0F1KfljeOpelS9S",
    "merchant_id": "postman_merchant_GHAction_0960f2ad-f7eb-40b6-b26e-76f7b2c8a314",
    "status": "requires_capture",
    "amount": 1000,
    "net_amount": 1000,
    "shipping_cost": null,
    "amount_capturable": 1000,
    "amount_received": null,
    "connector": "cybersource",
    "client_secret": "pay_lNsJx0F1KfljeOpelS9S_secret_smChi9KPNC8npC6RrMRM",
    "created": "2025-01-22T05:59:00.160Z",
    "currency": "USD",
    "customer_id": "cust_no_pm",
    "customer": {
        "id": "cust_no_pm",
        "name": null,
        "email": "guest@example.com",
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "0000",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "491761",
            "card_extended_bin": null,
            "card_exp_month": "03",
            "card_exp_year": "30",
            "card_holder_name": "joseph Doe",
            "payment_checks": {
                "avs_response": {
                    "code": "Y",
                    "codeRaw": "Y"
                },
                "card_verification": null
            },
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": "token_X2vJwiKJaVZGGBlHyCAl",
    "shipping": null,
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": null,
    "phone": null,
    "return_url": null,
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "debit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "cust_no_pm",
        "created_at": 1737525540,
        "expires": 1737529140,
        "secret": "epk_ee0b15d3ac32418c85bc7db03112c46c"
    },
    "manual_retry_allowed": false,
    "connector_transaction_id": "7375255413326173904805",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_lNsJx0F1KfljeOpelS9S_1",
    "payment_link": null,
    "profile_id": "pro_fuk87m6LvjQtft86rwDM",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_iFThtaTcJgCADiOBnpnG",
    "incremental_authorization_allowed": true,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2025-01-22T06:14:00.160Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "13.232.74.226",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2025-01-22T05:59:02.003Z",
    "split_payments": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Capture call

curl --location 'http://localhost:8080/payments/pay_lNsJx0F1KfljeOpelS9S/capture' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key:******8' \
--data '{
    "amount_to_capture": 1000,
    "statement_descriptor_name": "Joseph",
    "statement_descriptor_suffix": "JS"
}'

Response

{
    "payment_id": "pay_lNsJx0F1KfljeOpelS9S",
    "merchant_id": "postman_merchant_GHAction_0960f2ad-f7eb-40b6-b26e-76f7b2c8a314",
    "status": "processing",
    "amount": 1000,
    "net_amount": 1000,
    "shipping_cost": null,
    "amount_capturable": 1000,
    "amount_received": null,
    "connector": "cybersource",
    "client_secret": "pay_lNsJx0F1KfljeOpelS9S_secret_smChi9KPNC8npC6RrMRM",
    "created": "2025-01-22T05:59:00.160Z",
    "currency": "USD",
    "customer_id": "cust_no_pm",
    "customer": {
        "id": "cust_no_pm",
        "name": null,
        "email": "guest@example.com",
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "0000",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "491761",
            "card_extended_bin": null,
            "card_exp_month": "03",
            "card_exp_year": "30",
            "card_holder_name": "joseph Doe",
            "payment_checks": {
                "avs_response": {
                    "code": "Y",
                    "codeRaw": "Y"
                },
                "card_verification": null
            },
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": "token_X2vJwiKJaVZGGBlHyCAl",
    "shipping": null,
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": null,
    "phone": null,
    "return_url": null,
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "debit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "7377201269126748303954",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_lNsJx0F1KfljeOpelS9S_1",
    "payment_link": null,
    "profile_id": "pro_fuk87m6LvjQtft86rwDM",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_iFThtaTcJgCADiOBnpnG",
    "incremental_authorization_allowed": false,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2025-01-22T06:14:00.160Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "13.232.74.226",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2025-01-22T05:59:08.242Z",
    "split_payments": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Psync

curl --location 'http://localhost:8080/payments/pay_78YAFiVnkKgXA0j3xTjc?force_sync=true' \
--header 'Accept: application/json' \
--header 'api-key: dev_6kiThdH4P6mBBPHdwXYItx4btqxOFYkIMlOnnuhm2Mf3y3puFoZsi8pt3hIm4BJq'

Response

{
    "payment_id": "pay_78YAFiVnkKgXA0j3xTjc",
    "merchant_id": "postman_merchant_GHAction_dfe9803e-7fd8-473e-89d6-9fbf749f1f1f",
    "status": "succeeded",
    "amount": 1000,
    "net_amount": 1000,
    "shipping_cost": null,
    "amount_capturable": 0,
    "amount_received": 1000,
    "connector": "cybersource",
    "client_secret": "pay_78YAFiVnkKgXA0j3xTjc_secret_q1IxnrvhYEjKVC7y0wM9",
    "created": "2025-01-24T12:01:59.112Z",
    "currency": "USD",
    "customer_id": "cust_no_pm",
    "customer": {
        "id": "cust_no_pm",
        "name": "박 성 준",
        "email": "guest@example.com",
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "4242",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "424242",
            "card_extended_bin": null,
            "card_exp_month": "03",
            "card_exp_year": "30",
            "card_holder_name": "joseph Doe",
            "payment_checks": {
                "avs_response": {
                    "code": "Y",
                    "codeRaw": "Y"
                },
                "card_verification": null
            },
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": "token_lRVuuoX4WGATxCGmBEoQ",
    "shipping": null,
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "박성준",
            "last_name": "박성준"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "order_details": null,
    "email": "guest@example.com",
    "name": "박 성 준",
    "phone": null,
    "return_url": null,
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "debit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "7377201269126748303954",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_78YAFiVnkKgXA0j3xTjc_1",
    "payment_link": null,
    "profile_id": "pro_oEimuIUyzLP64DhYs9uv",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_pijohfcR2jaEvPLtc1mQ",
    "incremental_authorization_allowed": false,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2025-01-24T12:16:59.112Z",
    "fingerprint": null,
    "browser_info": {
        "language": "nl-NL",
        "time_zone": 0,
        "ip_address": "13.232.74.226",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 1536,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 723,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2025-01-27T07:50:54.314Z",
    "split_payments": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-01-22T06:07:22Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs	0% smaller

Gnanasundari24 · 2025-01-27T07:29:33Z

@AkshayaFoiger Where are we sending isFinal flag?
In the payload or connector_request. Please add the detailed testcases to verify

AkshayaFoiger · 2025-01-27T07:56:03Z

@AkshayaFoiger Where are we sending isFinal flag? In the payload or connector_request. Please add the detailed testcases to verify

I have added the capture call test case above. The change made in this PR will only affect CyberSource's capture call. CyberSource does not provide an explicit response for sending this flag. Instead, this flag is expected to be passed from CyberSource to the issuer bank.

Hence the the responsibility of releasing remaining authorized amount is being delegated to the issuer bank.

…-connectors * 'main' of github.com:juspay/hyperswitch: ci: disable stripe in cypress (#7183) fix(router): [Cybersource] add flag to indicate final capture (#7085) fix: invalidate surcharge cache during update (#6907) chore(version): 2025.02.04.0 fix(samsung_pay): populate `payment_method_data` in the payment response (#7095) feat(router): add core changes for external authentication flow through unified_authentication_service (#7063) fix(connector): [NETCETERA] add `sdk-type` and `default-sdk-type` in netcetera authentication request (#7156)

fix(router): add isFinal to cybersource

6f7c337

AkshayaFoiger self-assigned this Jan 22, 2025

AkshayaFoiger requested a review from a team as a code owner January 22, 2025 06:07

AkshayaFoiger changed the title ~~fix(router): add isFinal to cybersource~~ fix(router): [cybersource] add flag to indicate final capture Jan 22, 2025

AkshayaFoiger changed the title ~~fix(router): [cybersource] add flag to indicate final capture~~ fix(router): [Cybersource] add flag to indicate final capture Jan 22, 2025

deepanshu-iiitu previously approved these changes Jan 22, 2025

View reviewed changes

swangi-kumari previously approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'main' into cybersource-capture-fix

3465713

AkshayaFoiger dismissed stale reviews from swangi-kumari and deepanshu-iiitu via 3465713 January 23, 2025 10:09

add is_finale flag to capture request

dd058e8

AkshayaFoiger requested review from deepanshu-iiitu and swangi-kumari January 23, 2025 10:28

deepanshu-iiitu previously approved these changes Jan 23, 2025

View reviewed changes

swangi-kumari previously approved these changes Jan 23, 2025

View reviewed changes

chore: run formatter

15f9e0e

hyperswitch-bot bot dismissed stale reviews from swangi-kumari and deepanshu-iiitu via 15f9e0e January 23, 2025 10:34

deepanshu-iiitu approved these changes Jan 24, 2025

View reviewed changes

deepanshu-iiitu requested a review from swangi-kumari January 24, 2025 06:52

swangi-kumari approved these changes Jan 24, 2025

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Jan 27, 2025

Gnanasundari24 removed this pull request from the merge queue due to a manual request Jan 27, 2025

Gnanasundari24 added this pull request to the merge queue Jan 31, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 31, 2025

Gnanasundari24 added this pull request to the merge queue Feb 3, 2025

Merged via the queue into main with commit 55bb284 Feb 4, 2025
39 of 40 checks passed

Gnanasundari24 deleted the cybersource-capture-fix branch February 4, 2025 01:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(router): [Cybersource] add flag to indicate final capture #7085

fix(router): [Cybersource] add flag to indicate final capture #7085
Gnanasundari24 merged 4 commits intomainfrom
cybersource-capture-fix

AkshayaFoiger commented Jan 22, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

Gnanasundari24 commented Jan 27, 2025

Uh oh!

AkshayaFoiger commented Jan 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AkshayaFoiger commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gnanasundari24 commented Jan 27, 2025

Uh oh!

AkshayaFoiger commented Jan 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AkshayaFoiger commented Jan 22, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 22, 2025 •

edited

Loading