feat(core): add support for confirmation flow for click to pay by sahkal · Pull Request #6982 · juspay/hyperswitch

sahkal · 2025-01-03T10:19:23Z

Type of Change

New feature

Description

Add support for confirmation flow for click to pay

currenlty in cick to pay we do authentication with mastercard and authorisation with adyen.

But to be prod certified mastercard needs a confirmation notification from hyperswitch after authorisation stating the state of the transaction.

So, in this Pr I have added confirmation flow for click to pay

How did you test it?

Add config to make the merchant eligible for authentication service

curl --location 'http://localhost:8080/configs/' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
    "key": "merchants_eligible_for_authentication_service",
    "value": "[\"sahkal\", \"cewqcewc\", \"dqwdwljildwduoqwhduwqcqwjd\"]"
}'

Create merchant connector account for Ctp_mastercard

curl --location 'http://localhost:8080/account/dqwdwljildwduoqwhduwqcqwjd/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '
{
    "connector_type": "authentication_processor",
    "connector_name": "ctp_mastercard",
    "connector_account_details": {
        "auth_type": "HeaderKey",
        "api_key": "API-KEY"
    },
    "test_mode": true,
    "disabled": false,
    "payment_methods_enabled": [
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "business_country": "US",
    "business_label": "default",
     "metadata": {
    "dpa_id": "b6e06cc6-3018-4c4c-bbf5-9fb232615090",
    "dpa_name": "TestMerchant",
    "locale": "en_AU",
    "card_brands": ["mastercard", "visa"],
    "acquirer_bin": "545301",
    "acquirer_merchant_id": "SRC3DS",
    "merchant_category_code": "0001",
    "merchant_country_code": "US"
  }
}
'

Adyen

curl --location 'http://localhost:8080/account/dqwdwljildwduoqwhduwqcqwjd/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '
{
    "connector_type": "payment_processor",
    "connector_name": "adyen",
    "connector_account_details": {
        "auth_type": "SignatureKey",
        "api_key": "API-KEY",
        "key1": "KEY-1",
        "api_secret": "API-SECRET"
    },
    "test_mode": true,
    "disabled": false,
    "payment_methods_enabled": [
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "metadata": {
        "city": "NY",
        "unit": "245",
        "live_endpoint_prefix": "vsfbjh"
    },
    "connector_webhook_details": {
        "merchant_secret": "MERCHANT SECRET"
    },
    "business_country": "US",
    "business_label": "default"
}
'

update business profile with ctp_mastercard mca_id

curl --location 'http://localhost:8080/account/dqwdwljildwduoqwhduwqcqwjd/business_profile/pro_KCTRv8sFQfC0r65CZxrn' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
    "is_click_to_pay_enabled": true,
    "authentication_product_ids": {"click_to_pay": "mca_XAXUpel8ABbpoGNF8lGz"}
}'

do payments create

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_fQsdc9JbERQ7CWvmguo84XDROuXOD1oK9sdfCJXOko3SossoI4zdxpJkOIPmojwn' \
--data '{
    "amount": 1130,
    "currency": "USD",
    "confirm": false,
    "return_url": "https://hyperswitch.io"
    }   
'

do payments confirm

curl --location 'http://localhost:8080/payments/pay_Ft9Ke5Lun924OCJa7yll/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_1f712ac5fd7f4d8c91da6a627862a4f0' \
--data '
{
    
      "payment_method": "card",
    "payment_method_type": "debit",
    "client_secret": "pay_Ft9Ke5Lun924OCJa7yll_secret_po1FVW5adQWFolWJUhMb",
    "ctp_service_details" : {
        "merchant_transaction_id": "0a4e0d3.34f4a04b.803eb38b0a56f082296538d4a70c064a6b320639",
        "correlation_id": "34f4a04b.bcd1ac39-e0f3-479e-b3ee-703ade0c66dc",
        "x_src_flow_id" : "34f4a04b.bcd1ac39-e0f3-479e-b3ee-703ade0c66dc.1727438793"
    },
    "browser_info": {
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "color_depth": 24,
        "java_enabled":true,
        "java_script_enabled": true,
        "language": "en-GB",
        "screen_height":  1440,
        "screen_width": 2560,
        "time_zone": -330,
        "user_agent": "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Mobile Safari/537.36"
    }
}'

Expected Response

{
    "payment_id": "pay_Ft9Ke5Lun924OCJa7yll",
    "merchant_id": "dqwdwljildwduoqwhduwqcqwjd",
    "status": "failed",
    "amount": 1130,
    "net_amount": 1130,
    "shipping_cost": null,
    "amount_capturable": 0,
    "amount_received": null,
    "connector": "adyen",
    "client_secret": "pay_Ft9Ke5Lun924OCJa7yll_secret_po1FVW5adQWFolWJUhMb",
    "created": "2024-12-18T13:00:47.663Z",
    "currency": "USD",
    "customer_id": null,
    "customer": null,
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": null,
    "payment_method": "card",
    "payment_method_data": null,
    "payment_token": null,
    "shipping": null,
    "billing": null,
    "order_details": null,
    "email": null,
    "name": null,
    "phone": null,
    "return_url": "https://hyperswitch.io/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": "2",
    "error_message": "Refused",
    "unified_code": "UE_9000",
    "unified_message": "Something went wrong",
    "payment_experience": null,
    "payment_method_type": "debit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": true,
    "connector_transaction_id": "KN8X64SH6PRRVS65",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_KCTRv8sFQfC0r65CZxrn",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_L6N77PiH3BI2BTPwkZPL",
    "incremental_authorization_allowed": false,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-12-18T13:15:47.663Z",
    "fingerprint": null,
    "browser_info": {
        "language": "en-GB",
        "time_zone": -330,
        "ip_address": "::1",
        "user_agent": "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Mobile Safari/537.36",
        "color_depth": 24,
        "java_enabled": true,
        "screen_width": 2560,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "screen_height": 1440,
        "java_script_enabled": true
    },
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-12-18T13:04:08.461Z",
    "split_payments": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Reason for it being failed is ayden doesn't support click to pay in sandbox, but does support in production

Look for confirmation call in logs

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…2-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name

…_id-and-get-the-connector-creds-instead-of-connector_name

…-the-connector-creds-instead-of-connector_name' of https://github.com/juspay/hyperswitch into 7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name

…_id-and-get-the-connector-creds-instead-of-connector_name

semanticdiff-com · 2025-01-03T10:19:26Z

Review changes with

Changed Files

File	Status
crates/router/src/types.rs	88% smaller
crates/hyperswitch_connectors/src/connectors/datatrans/transformers.rs	83% smaller
crates/router/src/connector/checkout/transformers.rs	83% smaller
crates/router/src/core/payments/operations/payment_confirm.rs	82% smaller
crates/hyperswitch_domain_models/src/types.rs	67% smaller
crates/router/src/connector/nmi/transformers.rs	65% smaller
crates/router/src/core/payments/types.rs	60% smaller
crates/hyperswitch_interfaces/src/types.rs	49% smaller
crates/hyperswitch_domain_models/src/router_request_types.rs	48% smaller
crates/hyperswitch_interfaces/src/api.rs	39% smaller
crates/router/src/core/payments/helpers.rs	18% smaller
crates/router/src/core/payments/connector_integration_v2_impls.rs	10% smaller
crates/router/src/core/payments/flows.rs	9% smaller
crates/router/src/core/unified_authentication_service.rs	8% smaller
crates/hyperswitch_connectors/src/connectors/unified_authentication_service.rs	8% smaller
crates/hyperswitch_connectors/src/default_implementations.rs	6% smaller
crates/hyperswitch_connectors/src/connectors/unified_authentication_service/transformers.rs	5% smaller
crates/router/src/core/payments.rs	4% smaller
crates/router/src/core/unified_authentication_service/types.rs	2% smaller
crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs	0% smaller
crates/hyperswitch_connectors/src/connectors/wellsfargo/transformers.rs	0% smaller
crates/hyperswitch_domain_models/src/router_flow_types/unified_authentication_service.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types/unified_authentication_service.rs	0% smaller
crates/router/src/core/payments/operations.rs	0% smaller
crates/router/src/core/unified_authentication_service/utils.rs	Unsupported file format

…ow-for-click-to-pay

…5-feature-add-support-for-confirmation-flow-for-click-to-pay

crates/router/src/core/unified_authentication_service/utils.rs

ShankarSinghC · 2025-02-12T11:35:20Z

crates/router/src/core/payments.rs

                    &business_profile,
                    &key_store,
                    mandate_type,
+                    &false,


As this does not provide the information about what is this field, can we make this as enum for better readability ?

ShankarSinghC · 2025-02-12T11:45:09Z

crates/router/src/core/unified_authentication_service/utils.rs

+            Some("Approval Code received".to_string()),
+        ),
+        _ => (
+            Some("03".to_string()),


Can we please give code comments for this hardcoding

The reason for the code is provided, which states based in transaction we need to send 02 to mastercard stating approval code received and same for code 03

* 'main' of github.com:juspay/hyperswitch: fix(connector): [DATATRANS] Fix Force Sync Flow (#7331) chore(version): 2025.02.21.0 fix(connector): [DATATRANS] Add new payment status (#7327) feat(router): [Xendit] add support for split payments (#7143) fix(payment_methods_v2): update fingerprint implementation in v2 (#7270) feat(router): Add Payments - List endpoint for v2 (#7191) feat(core): add support for confirmation flow for click to pay (#6982) chore(version): 2025.02.20.0 fix(connector): [SCRIPT] Update template generating script and updated connector doc (#7301) ci(cypress): add assertions for `requires_cvv` (#7296) refactor(utils): match string for state with SDK's naming convention (#7300) feat(core): add hypersense integration api (#7218) chore(version): 2025.02.19.0 feat(connector): [Moneris] Add payments flow (#7249) feat(core): api ,domain and diesel model changes for extended authorization (#6607) feat(payments): [Payment links] Add configs for payment link (#7288)

…tusedPM * 'main' of github.com:juspay/hyperswitch: (22 commits) feat(connector): add Samsung pay mandate support for Cybersource (#7298) chore(masking): add peek_mut to PeekInterface (#7281) feat(samsung_pay): collect customer address details form Samsung Pay based on business profile config and connector required fields (#7320) ci: update creds (#7345) feat(router): add `merchant_configuration_id` in netcetera metadata and make other merchant configurations optional (#7347) fix(routing): Fixed 5xx error logs in dynamic routing metrics (#7335) fix(connector): [DATATRANS] Fix Force Sync Flow (#7331) chore(version): 2025.02.21.0 fix(connector): [DATATRANS] Add new payment status (#7327) feat(router): [Xendit] add support for split payments (#7143) fix(payment_methods_v2): update fingerprint implementation in v2 (#7270) feat(router): Add Payments - List endpoint for v2 (#7191) feat(core): add support for confirmation flow for click to pay (#6982) chore(version): 2025.02.20.0 fix(connector): [SCRIPT] Update template generating script and updated connector doc (#7301) ci(cypress): add assertions for `requires_cvv` (#7296) refactor(utils): match string for state with SDK's naming convention (#7300) feat(core): add hypersense integration api (#7218) chore(version): 2025.02.19.0 feat(connector): [Moneris] Add payments flow (#7249) ...

sahkal and others added 16 commits December 17, 2024 16:21

refactor(router): fixed mca logic fetch

5f694cf

dummy commit

5d0d9d1

chore: run formatter

6e4bc87

Merge branch 'main' of https://github.com/juspay/hyperswitch into 786…

c7a0b06

…2-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name

addressed pr comments

3c2e034

fixed path url for uas

60a60e1

resolved conflicts

a97f01e

addressed pr comments

55029ed

Merge branch 'main' into 7862-refactor-refactor-ctp-flow-to-fetch-mca…

0e7922b

…_id-and-get-the-connector-creds-instead-of-connector_name

moved external 3ds under else condition

98b5af4

Merge branch '7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get…

edae612

…-the-connector-creds-instead-of-connector_name' of https://github.com/juspay/hyperswitch into 7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name

addressed pr comments

be0ffa9

resolved pr comments

5b4178b

addressed pr comments

2e791d5

Merge branch 'main' into 7862-refactor-refactor-ctp-flow-to-fetch-mca…

389ae52

…_id-and-get-the-connector-creds-instead-of-connector_name

feat(core): added confirmation flow for mastercard click to pay

733b05e

sahkal added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 3, 2025

sahkal added this to the December 2024 Release milestone Jan 3, 2025

sahkal self-assigned this Jan 3, 2025

sahkal requested review from a team as code owners January 3, 2025 10:19

sahkal added 2 commits January 3, 2025 15:56

resolved merge conflicts

01995ab

fixed spell check

b3f6ef4

sahkal requested review from jarnura and sai-harsha-vardhan January 3, 2025 10:29

docs(openapi): re-generate OpenAPI specification

fa20e5c

sahkal and others added 3 commits February 10, 2025 13:48

Merge branch 'main' into 7925-feature-add-support-for-confirmation-fl…

98acf9f

…ow-for-click-to-pay

Merge branch 'main' of https://github.com/juspay/hyperswitch into 792…

a65322e

…5-feature-add-support-for-confirmation-flow-for-click-to-pay

fixed clippy connector errors

6519efd

sahkal mentioned this pull request Feb 11, 2025

feat(core): add card_discovery filter to payment list and payments Response #7230

Merged

8 tasks

sai-harsha-vardhan previously approved these changes Feb 11, 2025

View reviewed changes

crates/router/src/core/unified_authentication_service/utils.rs Show resolved Hide resolved

sahkal requested a review from deepanshu-iiitu February 11, 2025 12:26

deepanshu-iiitu previously approved these changes Feb 12, 2025

View reviewed changes

ShankarSinghC previously approved these changes Feb 12, 2025

View reviewed changes

resolved merge conflicts

59bf3b9

sahkal dismissed stale reviews from ShankarSinghC, deepanshu-iiitu, and sai-harsha-vardhan via 59bf3b9 February 17, 2025 07:57

fixed v2 clippy error

3527d0d

sahkal removed the request for review from jarnura February 17, 2025 10:41

deepanshu-iiitu previously approved these changes Feb 18, 2025

View reviewed changes

addressed pr comments

def51e2

sahkal dismissed deepanshu-iiitu’s stale review via def51e2 February 19, 2025 09:09

removed variable mutability

492b7a3

ShankarSinghC approved these changes Feb 19, 2025

View reviewed changes

deepanshu-iiitu approved these changes Feb 19, 2025

View reviewed changes

sai-harsha-vardhan approved these changes Feb 19, 2025

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Feb 20, 2025

Merged via the queue into main with commit 74bbf4b Feb 20, 2025
17 of 20 checks passed

Gnanasundari24 deleted the 7925-feature-add-support-for-confirmation-flow-for-click-to-pay branch February 20, 2025 08:04

SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 23, 2025

sahkal mentioned this pull request May 14, 2025

refactor(authentication): moved cavv storing from table to temp locker #8022

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): add support for confirmation flow for click to pay#6982

feat(core): add support for confirmation flow for click to pay#6982
Gnanasundari24 merged 67 commits intomainfrom
7925-feature-add-support-for-confirmation-flow-for-click-to-pay

sahkal commented Jan 3, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

ShankarSinghC Feb 12, 2025

Uh oh!

ShankarSinghC Feb 12, 2025

Uh oh!

sahkal Feb 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

sahkal commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ShankarSinghC Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

ShankarSinghC Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

sahkal Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sahkal commented Jan 3, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 3, 2025 •

edited

Loading