feat(core): added customer phone_number and email to session token response for click to pay by sahkal · Pull Request #6863 · juspay/hyperswitch

sahkal · 2024-12-17T12:10:19Z

Type of Change

Enhancement

Description

Add customer phone_number and email to session token response for click to pay

How did you test it?

Add Ctp_mastercard as a connector and send relevant details to ctp in connector metadata

curl --location 'http://localhost:8080/account/dqwdwljildqwjd/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '

{
    "connector_type": "authentication_processor",
    "connector_name": "ctp_mastercard",
    "connector_account_details": {
        "auth_type": "HeaderKey",
        "api_key": "API-KEY"
    },
    "test_mode": true,
    "disabled": false,
    "payment_methods_enabled": [
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "business_country": "US",
    "business_label": "default",
     "metadata": {
    "dpa_id": "b6e06cc6-3018-4c4c-bbf5-9fb232615090",
    "dpa_name": "TestMerchant",
    "locale": "en_AU",
    "card_brands": ["mastercard", "visa"],
    "acquirer_bin": "545301",
    "acquirer_merchant_id": "SRC3DS",
    "merchant_category_code": "0001",
    "merchant_country_code": "US"
  }
}
'

update business profile with

"is_click_to_pay_enabled": true,
"authentication_product_ids": {"click_to_pay": "mca_id"}

Do payments create with customer details

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_myZVgK2frn2tWuTghpqBw4YmFcVOKoQ0etjGKyZCdegwHvKiGQgZOvhGsu7ShkaU' \
--data-raw '{
    "amount": 1130,
    "currency": "USD",
    "confirm": false,
    "return_url": "https://hyperswitch.io",
    "customer": {
        "email": "john@example.com",
        "id": "cus_abcdccqjciefgh",
        "name": "John Dough",
        "phone": "9123456789"
  } 
}'

Look for customer details in click to pay session response

curl --location 'http://localhost:8080/payments/session_tokens' \
--header 'Content-Type: application/json' \
--header 'x-feature: integ-custom' \
--header 'api-key: pk_dev_a82510aa11054218bfbae152586fb16d' \
--data '{
    "payment_id": "pay_gEidbQrgy29Hu2JfUWto",
    "client_secret": "pay_gEidbQrgy29Hu2JfUWto_secret_PfoMiqnCRZL3uCKrNDmv",
    "wallets": []
}
'

Response

{
    "payment_id": "pay_gEidbQrgy29Hu2JfUWto",
    "client_secret": "pay_gEidbQrgy29Hu2JfUWto_secret_PfoMiqnCRZL3uCKrNDmv",
    "session_token": [
        {
            "wallet_name": "click_to_pay",
            "dpa_id": "b6e06cc6-3018-4c4c-bbf5-9fb232615090",
            "dpa_name": "TestMerchant",
            "locale": "en_AU",
            "card_brands": [
                "mastercard",
                "visa"
            ],
            "acquirer_bin": "545301",
            "acquirer_merchant_id": "SRC3DS",
            "merchant_category_code": "0001",
            "merchant_country_code": "US",
            "transaction_amount": "11.30",
            "transaction_currency_code": "USD",
            "phone_number": "9123456789",
            "email": "john@example.com"
        }
    ]
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…sponse for click to pay

semanticdiff-com · 2024-12-17T12:10:22Z

Review changes with

Changed Files

File	Status
crates/router/src/core/payments.rs	2% smaller
api-reference-v2/openapi_spec.json	0% smaller
api-reference/openapi_spec.json	0% smaller
crates/api_models/src/payments.rs	0% smaller

…ptional customer data

crates/router/src/core/payments.rs

…se' of https://github.com/juspay/hyperswitch into 7863-add-email-and-phone-number-to-session-token-response

crates/api_models/src/payments.rs

…oken-response

crates/router/src/core/payments.rs

…ete-pm * 'main' of github.com:juspay/hyperswitch: refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats (#6853) refactor(customers_v2): include minor fixes for customer v2 flows (#6876) fix: cypress reports generation (#6894) fix(connector): Paypal BankRedirects (Ideal/EPS) (#6864) chore(version): 2024.12.19.1 fix(connector): [UNIFIED_AUTHENTICATION_SERVICE] change url path to `pre_authentication_processing` in pre-auth flow (#6885) refactor(users): move roles schema to global interface (#6862) feat(payment_methods): add support to pass apple pay recurring details to obtain apple pay merchant token (#6770) feat(payments): [Payment links] Add config for changing button text for payment links (#6860) feat(core): added customer phone_number and email to session token response for click to pay (#6863) FEAT(klarna): Klarna Kustom Checkout Integration (#6839) feat(users): handle email url for users in different tenancies (#6809) chore(version): 2024.12.19.0 refactor(dynamic_routing): update the authentication for update config to include JWT type (#6785) chore(env): remove unified_authentication_service base_url from integ, sandbox and production toml (#6865)

feat(core): added customer phone_number and email to session token re…

d262013

…sponse for click to pay

sahkal added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 17, 2024

sahkal added this to the December 2024 Release milestone Dec 17, 2024

sahkal self-assigned this Dec 17, 2024

sahkal requested review from a team as code owners December 17, 2024 12:10

sahkal requested review from SanchithHegde, ShankarSinghC and sai-harsha-vardhan December 17, 2024 12:10

hyperswitch-bot bot and others added 5 commits December 17, 2024 12:24

chore: run formatter

4d4d812

added phone_country_code in response also added validation check on o…

c2c80a8

…ptional customer data

added phone_country_code in response also added validation check on o…

080bb5e

…ptional customer data

fixed clippy error

d74937e

fixed open api specs

321aa00

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Dec 18, 2024

fixed email open api specs

85db722

sai-harsha-vardhan reviewed Dec 18, 2024

View reviewed changes

crates/router/src/core/payments.rs Outdated Show resolved Hide resolved

sahkal and others added 4 commits December 18, 2024 11:54

fixed open api specs

02a56b3

docs(openapi): re-generate OpenAPI specification

b97061d

resolved pr comments

586ac26

Merge branch '7863-add-email-and-phone-number-to-session-token-respon…

f8fdd94

…se' of https://github.com/juspay/hyperswitch into 7863-add-email-and-phone-number-to-session-token-response

SanchithHegde reviewed Dec 18, 2024

View reviewed changes

crates/api_models/src/payments.rs Outdated Show resolved Hide resolved

changed phone number to secret?

79067df

sahkal requested review from SanchithHegde and sai-harsha-vardhan December 18, 2024 06:55

hyperswitch-bot bot and others added 2 commits December 18, 2024 06:57

docs(openapi): re-generate OpenAPI specification

6d05461

Merge branch 'main' into 7863-add-email-and-phone-number-to-session-t…

19fca42

…oken-response

sai-harsha-vardhan previously approved these changes Dec 18, 2024

View reviewed changes

SanchithHegde reviewed Dec 18, 2024

View reviewed changes

crates/router/src/core/payments.rs Outdated Show resolved Hide resolved

used parse_value instead of serde_json::from_value

4ccb2ee

sahkal dismissed sai-harsha-vardhan’s stale review via 4ccb2ee December 19, 2024 06:44

sahkal requested review from SanchithHegde and sai-harsha-vardhan December 19, 2024 06:44

fixed customer_details requirement logic

fda4a1c

sai-harsha-vardhan previously approved these changes Dec 19, 2024

View reviewed changes

SanchithHegde reviewed Dec 19, 2024

View reviewed changes

crates/router/src/core/payments.rs Outdated Show resolved Hide resolved

addressed pr comments

5d92813

sahkal dismissed sai-harsha-vardhan’s stale review via 5d92813 December 19, 2024 09:40

sahkal requested review from SanchithHegde and sai-harsha-vardhan December 19, 2024 09:41

removed unnecessary change context

40241a7

SanchithHegde approved these changes Dec 19, 2024

View reviewed changes

sai-harsha-vardhan approved these changes Dec 19, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Dec 19, 2024

Merged via the queue into main with commit 092c79e Dec 19, 2024

Gnanasundari24 deleted the 7863-add-email-and-phone-number-to-session-token-response branch December 19, 2024 12:03

SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): added customer phone_number and email to session token response for click to pay#6863

feat(core): added customer phone_number and email to session token response for click to pay#6863
Gnanasundari24 merged 18 commits intomainfrom
7863-add-email-and-phone-number-to-session-token-response

sahkal commented Dec 17, 2024 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sahkal commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sahkal commented Dec 17, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 17, 2024 •

edited

Loading