Skip to content

feat(webhooks): adyen - consume and update connector's network_transaction_id in payment_methods#6738

Merged
likhinbopanna merged 10 commits intomainfrom
6719-adyen-network-transaction-id
Dec 5, 2024
Merged

feat(webhooks): adyen - consume and update connector's network_transaction_id in payment_methods#6738
likhinbopanna merged 10 commits intomainfrom
6719-adyen-network-transaction-id

Conversation

@kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Dec 4, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in #6719

This PR introduces below changes

  • get_network_txn_id fn in IncomingWebhook trait
  • implement this new fn for Adyen for retrieving the network txn ID
  • consume this fn in core flows for updating network_transaction_id in payment_methods table

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Helps persist network transaction IDs for connectors in case it was not present in Authorize or Capture responses but instead sent in the webhook!

How did you test it?

  • Ensure Adyen is configured in HS, along with webhooks!
  • Ensure network_tx_reference (field in Adyen) is not returned in Authorize or Capture response
  • This field should be populated in DB once webhooks are received (provided this field was also returned)

network_transaction_id is populated after receiving webhooks
Screenshot 2024-12-04 at 4 45 43 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Dec 4, 2024
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 4, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/webhooks/incoming.rs  81% smaller
  crates/diesel_models/src/payment_method.rs  2% smaller
  crates/hyperswitch_domain_models/src/router_flow_types/webhooks.rs  0% smaller
  crates/hyperswitch_interfaces/src/webhooks.rs  0% smaller
  crates/router/src/connector/adyen.rs  0% smaller
  crates/router/src/connector/adyen/transformers.rs  0% smaller
  crates/router/src/services/connector_integration_interface.rs Unsupported file format

@kashif-m kashif-m marked this pull request as ready for review December 4, 2024 11:17
@kashif-m kashif-m requested review from a team as code owners December 4, 2024 11:17
@kashif-m kashif-m added A-connector-compatibility Area: Connector compatibility A-core Area: Core flows A-webhooks Area: Webhook flows A-tokenization Area: Network Tokenization A-mandates Area: Mandate Flows and removed A-tokenization Area: Network Tokenization labels Dec 4, 2024
srujanchikke
srujanchikke reviewed Dec 4, 2024
View reviewed changes
@kashif-m kashif-m requested a review from a team as a code owner December 4, 2024 13:39
@kashif-m kashif-m requested a review from srujanchikke December 4, 2024 13:41
@kashif-m kashif-m linked an issue Dec 4, 2024 that may be closed by this pull request
[BUG] mandate details are not persisted for Adyen connector #6719
Closed
2 tasks
jarnura
jarnura requested changes Dec 5, 2024
View reviewed changes
@kashif-m kashif-m requested a review from jarnura December 5, 2024 07:29
jarnura
jarnura previously approved these changes Dec 5, 2024
View reviewed changes
srujanchikke
srujanchikke previously approved these changes Dec 5, 2024
View reviewed changes
ShankarSinghC
ShankarSinghC previously approved these changes Dec 5, 2024
View reviewed changes
@kashif-m kashif-m dismissed stale reviews from ShankarSinghC, srujanchikke, and jarnura via 72a5e90 December 5, 2024 08:29
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 871a363 Dec 5, 2024
@likhinbopanna likhinbopanna deleted the 6719-adyen-network-transaction-id branch December 5, 2024 13:35
@kashif-m kashif-m mentioned this pull request Dec 5, 2024
Merged
14 tasks
kashif-m added a commit that referenced this pull request Dec 6, 2024
@kashif-m @hyperswitch-bot
feat(webhooks): adyen - consume and update connector's network_transa…
f47b37f 
…ction_id in payment_methods (#6738)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
(cherry picked from commit 871a363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarnura jarnura jarnura approved these changes

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@kashif-m kashif-m

Labels

A-connector-compatibility Area: Connector compatibility A-core Area: Core flows A-mandates Area: Mandate Flows A-webhooks Area: Webhook flows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] mandate details are not persisted for Adyen connector

5 participants

@kashif-m @jarnura @ShankarSinghC @srujanchikke @likhinbopanna