fix(router): get apple pay certificates only from metadata during the session call#6514
Merged
likhinbopanna merged 2 commits intomainfrom Nov 8, 2024
Merged
Conversation
Changed Files
|
3ae342e to
b6db425
Compare
b6db425 to
bd512fc
Compare
sai-harsha-vardhan
approved these changes
Nov 8, 2024
14 tasks
srujanchikke
approved these changes
Nov 8, 2024
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
… session call (#6514) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently we have apple pay certificates being stored in the
metadataas well asconnector_wallet_detailswhen a merchant connector account is created. During the session call we try to get the certificates from theconnector_wallet_detailsif it fails we try to get it frommetadata.Currently when apple pay certificates are being updated with the merchant connector update call only the metadata is being updated. Because of this
connector_wallet_detailswill still have the old data using which we make the session call.In order to fix it, this pr contains the changes to get the
apple pay certificatesfrom themetadataonly as it will have the latest updated data. In subsequent pr mca update inconsistency will be handled.Additional Changes
Motivation and Context
How did you test it?
-> Create merchant connector account with apple pay enabled (pass the certificates only in the metadata)
-> Create a payment with confirm false
-> Make a session call
-> Now update the mca with different apple pay session data and make the session call
Checklist
cargo +nightly fmt --allcargo clippy