Skip to content

Refactor(core): interpolate success_based_routing config params with their specific values#6448

Merged
Gnanasundari24 merged 23 commits intomainfrom
refactor/grpc_sr
Nov 8, 2024
Merged

Refactor(core): interpolate success_based_routing config params with their specific values#6448
Gnanasundari24 merged 23 commits intomainfrom
refactor/grpc_sr

Conversation

@prajjwalkumar17
Copy link
Member

@prajjwalkumar17 prajjwalkumar17 commented Oct 28, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This will interpolate the success_based_routing config params with the specific payment's values:
So for now the redis key was something like PaymentMethod:Currency
After this change it will be something like Card:USD

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

This is tested locally can't be tested on sbx or integ as it requires access for redis.
Screenshot 2024-11-07 at 5 14 06 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner October 28, 2024 08:12
@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 28, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payments.rs  27% smaller
  crates/router/src/core/routing/helpers.rs  7% smaller
  crates/router/src/core/payments/operations/payment_response.rs  2% smaller
  crates/api_models/src/routing.rs  0% smaller
  crates/external_services/src/grpc_client.rs  0% smaller
  crates/external_services/src/grpc_client/dynamic_routing.rs  0% smaller
  crates/router/src/core/errors.rs  0% smaller
  crates/router/src/core/payments/routing.rs  0% smaller

@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft October 28, 2024 08:12
@prajjwalkumar17 prajjwalkumar17 changed the title Refactor/grpc sr Refactor(core): interpolate params with their specific values Oct 28, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Nov 5, 2024
@prajjwalkumar17 prajjwalkumar17 marked this pull request as ready for review November 5, 2024 13:50
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners November 5, 2024 13:50
@prajjwalkumar17 prajjwalkumar17 added the A-routing Area: Routing label Nov 5, 2024
@prajjwalkumar17 prajjwalkumar17 linked an issue Nov 5, 2024 that may be closed by this pull request
Refactor: interpolate success based routing params with their specific values #6484
Closed
@prajjwalkumar17 prajjwalkumar17 added this to the October 2024 Release milestone Nov 5, 2024
@prajjwalkumar17 prajjwalkumar17 changed the title Refactor(core): interpolate params with their specific values Refactor(core): interpolate success_based_routing config params with their specific values Nov 5, 2024
Chethan-rao
Chethan-rao suggested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Chethan-rao Chethan-rao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u move the startup log which is getting logged even when feature is disabled

Chethan-rao
Chethan-rao suggested changes Nov 7, 2024
View reviewed changes
Chethan-rao
Chethan-rao suggested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@Chethan-rao Chethan-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test cases screen shots for displaying the redis keys

@NishantJoshi00
Copy link
Contributor

NishantJoshi00 commented Nov 7, 2024

good find

@ThisIsMani ThisIsMani removed the request for review from a team November 7, 2024 12:09
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit d9ce42f Nov 8, 2024
@Gnanasundari24 Gnanasundari24 deleted the refactor/grpc_sr branch November 8, 2024 13:06
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
@prajjwalkumar17 @hyperswitch-bot
Refactor(core): interpolate success_based_routing config params with …
60ac4b9 
…their specific values (#6448)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorvdixit88 apoorvdixit88 Awaiting requested review from apoorvdixit88

2 more reviewers

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@Chethan-rao Chethan-rao Chethan-rao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels

A-routing Area: Routing

Projects

None yet

Milestone

November 2024 Release

Development

Successfully merging this pull request may close these issues.

Refactor: interpolate success based routing params with their specific values

5 participants

@prajjwalkumar17 @NishantJoshi00 @Chethan-rao @SanchithHegde @Gnanasundari24