refactor(business_profile): change id for business profile#5748
Merged
likhinbopanna merged 8 commits intomainfrom Sep 2, 2024
Merged
refactor(business_profile): change id for business profile#5748likhinbopanna merged 8 commits intomainfrom
likhinbopanna merged 8 commits intomainfrom
Conversation
|
Review changes with SemanticDiff. Analyzed 22 of 27 files. Overall, the semantic diff is 59% smaller than the GitHub diff. File Information
|
SanchithHegde
approved these changes
Aug 30, 2024
| generics::generic_find_one::<<Self as HasTable>::Table, _, _>( | ||
| conn, | ||
| dsl::profile_id.eq(profile_id.to_owned()), | ||
| dsl_identifier.eq(profile_id.to_owned()), |
Contributor
There was a problem hiding this comment.
Can we have separate v1 and v2 functions, for more clarity as there's no profile_id in v2
sai-harsha-vardhan
approved these changes
Sep 2, 2024
ThisIsMani
approved these changes
Sep 2, 2024
Contributor
ThisIsMani
left a comment
There was a problem hiding this comment.
Dashboard specific changes looks fine.
Aprabhat19
approved these changes
Sep 2, 2024
prajjwalkumar17
approved these changes
Sep 2, 2024
pixincreate
added a commit
that referenced
this pull request
Sep 3, 2024
…config-fix * 'main' of github.com:juspay/hyperswitch: feat: add profile_id authentication for business profile update and list (#5673) chore(version): 2024.09.03.0 feat(user): implement invitations api (#5769) feat(connector): [Adyenplatform] add webhooks for payout (#5749) refactor(v2_migrations): re-organize v2 migrations (#5760) chore: add wasm support for connector additional details (#5712) refactor(connector): Move globepay, powertranz, tsys, worldline to hyperswitch_connectors (#5758) fix(cypress): fix cypress throwing error when `connectorId` is not passed and miscellaneous fixes (#5746) chore: fix typos (#5766) refactor(business_profile): change id for business profile (#5748)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR drops the id column and creates it again for v2 with varchar. Also
ApiVersionenum is added.Additional Changes
Motivation and Context
How did you test it?
This is a v2 specific change only. For business profiles table
Checklist
cargo +nightly fmt --allcargo clippy