Skip to content

refactor(euclid): check the authenticity of profile_id being used#5647

Merged
likhinbopanna merged 22 commits intomainfrom
refactor_routing_dashboard_related_changes
Sep 3, 2024
Merged

refactor(euclid): check the authenticity of profile_id being used#5647
likhinbopanna merged 22 commits intomainfrom
refactor_routing_dashboard_related_changes

Conversation

@prajjwalkumar17
Copy link
Member

@prajjwalkumar17 prajjwalkumar17 commented Aug 20, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This change will ensure that the profile id being sent in params, belongs to the merchant using them.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Cannot be tested right now because currently we are not including profile_id in JWT.
Was able to compile the code.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 added C-refactor Category: Refactor A-euclid-foc Area: Euclid Family of Crates labels Aug 20, 2024
@prajjwalkumar17 prajjwalkumar17 added this to the August 2024 Release milestone Aug 20, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Aug 20, 2024
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners August 20, 2024 08:17
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner August 21, 2024 10:43
@prajjwalkumar17 prajjwalkumar17 requested a review from racnan August 21, 2024 11:35
@ThisIsMani
Copy link
Contributor

retrieve_merchant_routing_dictionary should have 2 different endpoints.
One at merchant level and other at profile level as it is a list API. Refer #5589 for implementation.

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner August 29, 2024 09:57
ThisIsMani
ThisIsMani previously approved these changes Sep 3, 2024
jarnura
jarnura previously approved these changes Sep 3, 2024
kashif-m
kashif-m previously approved these changes Sep 3, 2024
kashif-m
kashif-m previously approved these changes Sep 3, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 0fb8e85 Sep 3, 2024
@likhinbopanna likhinbopanna deleted the refactor_routing_dashboard_related_changes branch September 3, 2024 13:23
pixincreate added a commit that referenced this pull request Sep 5, 2024
* 'main' of github.com:juspay/hyperswitch:
  feat(customer_v2): Add customer V2 delete api (#5518)
  chore(version): 2024.09.05.0
  feat(user_roles): get user role details (#5777)
  feat(users): Add profile level invites (#5793)
  refactor(router): profile based routes for payouts (#5794)
  Feat(connector): [Fiuu] Add Card Flows (#5786)
  fix(cypress): fix fiservemea configs for cypress (#5772)
  fix(cypress): `api_key` check in cypress (#5787)
  feat(payment_methods_v2): Implemented Diesel and Domain models for v2 (#5700)
  fix(payout): query for getting a list of active payout IDs (#5771)
  refactor(router): remove admin v2 intermediate features (#5780)
  feat(revert): populate payment method details in payments response (#5785)
  chore(version): 2024.09.04.0
  fix(connector): skip 3DS in `network_transaction_id` flow for cybersource (#5781)
  refactor(euclid): check the authenticity of profile_id being used (#5647)
  feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication (#5729)
  fix(router): make customer details None in the `Psync` flow if the customer is deleted (#5732)
  feat(connector): [DEUTSCHE] Add template code (#5774)
  chore(version): 2024.09.03.1
  fix(router): send post message to window.parent instead of window.top in external 3ds flow (#5778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-euclid-foc Area: Euclid Family of Crates C-refactor Category: Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REFACTOR: check the authenticity of profile_id being used for all the routing routes

10 participants