Skip to content

ci(cypress): Add routing testcases#5571

Merged
likhinbopanna merged 7 commits intomainfrom
routing_test
Aug 28, 2024
Merged

ci(cypress): Add routing testcases#5571
likhinbopanna merged 7 commits intomainfrom
routing_test

Conversation

@Gnanasundari24
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Added the Priority,VolumeBased,RuleBased routing testcases.
  • Refactored paymentIntentTest

How did you test it?

Ran the testcases in sandbox

Stripe
Screenshot 2024-08-07 at 6 54 12 PM

Routing
Screenshot 2024-08-08 at 3 43 33 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Gnanasundari24 Gnanasundari24 added A-CI-CD Area: Continuous Integration/Deployment C-test Category: Tests labels Aug 8, 2024
@Gnanasundari24 Gnanasundari24 added this to the August 2024 Release milestone Aug 8, 2024
@Gnanasundari24 Gnanasundari24 self-assigned this Aug 8, 2024
@Gnanasundari24 Gnanasundari24 requested review from a team as code owners August 8, 2024 10:41
expect(response.headers["content-type"]).to.include("application/json");
if (response.status === 200) {
globalState.set("paymentID", paymentIntentID);
globalState.set("connectorId", response.body.connector);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

This is not needed as globalState will always have connectorId as it is setup even before the tests start to run (you can check State.js for this).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For routing there is no where we are get to know which connector the testcases are running. Do you remember we already discussed about this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For routing there is no where we are get to know which connector the testcases are running.

Okay, but how are we getting to know about this? We are just setting the value here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever the confirm call happened it get know which connector it went in and handle redirection case will happen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this change. Can you also do the same for PML? This is very much needed.

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 27, 2024
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 28, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 150094f Aug 28, 2024
@likhinbopanna likhinbopanna deleted the routing_test branch August 28, 2024 10:10
pixincreate added a commit that referenced this pull request Aug 28, 2024
* 'main' of github.com:juspay/hyperswitch:
  feat(connector): [FISERVEMEA] Integrate cards (#5672)
  ci(cypress): Add routing testcases (#5571)
  fix(router): skip external three_ds flow for recurring payments (#5730)
  refactor(customer_v2): fixed customer_v2 create panic issue (#5699)
  feat(user_roles): support switch for new hierarchy (#5692)
  refactor(router): add domain type for merchant_connector_account id (#5685)
  refactor(cypress_tests): handle api keys check in api key list call (#5719)
  feat(connector): [NEXIXPAY] Add template code (#5684)
  refactor(connector): [itau] refactor error reason and code mapping for itau (#5718)
  fix(core): fix merchant connector account create for v2  (#5716)
  chore(version): 2024.08.28.0
  fix(routing): fix routing routes to deserialise correctly (#5724)
  feat(euclid): add a new variant in payment type i.e ppt_mandate (#5681)
  feat(core): Add mTLS certificates for each request (#5636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI-CD Area: Continuous Integration/Deployment C-test Category: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants