Merged
Conversation
…w removed in confirm-body fixture
pixincreate
commented
Jul 30, 2024
| }); | ||
|
|
||
| it("[Payment create] Invalid card number", () => { | ||
| let data = getConnectorDetails(globalState.get("commons"))["card_pm"][ |
Member
Author
There was a problem hiding this comment.
Using commons in here is intentional since we expect these to run against regardless of connector
Sakilmostak
requested changes
Jul 31, 2024
| "client_secret": "", | ||
| "return_url": "https://hyperswitch.io", | ||
| "confirm": true, | ||
| "payment_method": "card", |
Contributor
There was a problem hiding this comment.
What is the reason for removing payment method from fixtures and adding individually to each configs? Otherwise LGTM
Member
Author
There was a problem hiding this comment.
For corner cases, especially for confirm payment w/o pmd, we're not supposed to pass any payment_method info. With payment_method being existent in confirm_body fixture, it is being supplied in the request resulting in failures.
To over come this, I had to remove it from fixtures which resulted in other tests to fail forcing me to add at config level.
Sakilmostak
approved these changes
Jul 31, 2024
14 tasks
likhinbopanna
approved these changes
Aug 1, 2024
Gnanasundari24
approved these changes
Aug 1, 2024
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
* 'main' of github.com:juspay/hyperswitch: (37 commits) fix(connector): Fixed status mapping for Plaid (#5525) feat(core): accept profile_id in merchant_account, connectors and customers core functions (#5505) refactor(auth): Pass `profile_id` from the auth to core functions (#5520) refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config (#5478) refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488) feat(cypress): add corner cases (#5481) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds variation cases where Hyperswitch is known to get
4xxresponse. This is added as a part of regression test.Tests include, but not limited to:
To accommodate the changes for above, slight refactoring has been done to the configs where I've removed
payment_methodfromconfirm_bodyinfixturesand moved them to individual connector level configs.This also adds a check to
4xxerror body where we validate whether the error response is anobjector astring(required for invalid card length).This also forced me to fix issues with data trans connector.
This enhancement will be done in multiple PRs as I do not want to make it complicated unnecessarily.
Additional Changes
Motivation and Context
NIL
How did you test it?
Corner cases
There happens to be an issue with NMI:
It should expect
capture_methodto bemanualand should not be limited tomanual_multipleChecklist
prettier . --writecargo clippy