feat(router): add api_models and openapi changes for modular auth eligibility apis#10059
Merged
likhinbopanna merged 3 commits intomainfrom Nov 3, 2025
Conversation
|
Review changes with Changed Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10059 +/- ##
=======================================
Coverage ? 3.91%
=======================================
Files ? 1223
Lines ? 301236
Branches ? 0
=======================================
Hits ? 11804
Misses ? 289432
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /// Optional secret value used to identify and authorize the client making the request. | ||
| /// This can help ensure that the payment session is secure and valid. | ||
| #[schema(value_type = Option<String>)] | ||
| pub client_secret: Option<masking::Secret<String>>, |
Contributor
There was a problem hiding this comment.
can be taken in header
Contributor
Author
There was a problem hiding this comment.
Required for ClientSecretFetch impl on the request payload
Contributor
There was a problem hiding this comment.
This can be removed for now. We can introduce this later as well. Since optional field
| /// The unique identifier for this authentication. | ||
| /// Added in the request for api event metrics, populated from path parameter | ||
| #[serde(skip)] | ||
| pub authentication_id: id_type::AuthenticationId, |
Contributor
There was a problem hiding this comment.
If this is available in path, it should not be present here.
| #[cfg(feature = "v1")] | ||
| #[derive(Debug, Serialize, Deserialize, ToSchema)] | ||
| #[serde(rename_all = "snake_case")] | ||
| pub enum AuthenticationEligibilityCheckData { |
Contributor
There was a problem hiding this comment.
should this be a tagged enum?
hrithikesh026
previously approved these changes
Oct 30, 2025
tsdk02
previously approved these changes
Oct 30, 2025
f8b0a0a
tsdk02
approved these changes
Nov 3, 2025
hrithikesh026
approved these changes
Nov 3, 2025
aadityaguptaa
pushed a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add api_models and openapi changes for modular auth eligibility apis
Additional Changes
Motivation and Context
How did you test it?
No testing required, api model changes only
Checklist
cargo +nightly fmt --allcargo clippy