Use reusable workflow action for checking permissions in the update-snapshots bot#18334
Merged
krassowski merged 2 commits intojupyterlab:mainfrom Jan 14, 2026
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
martinRenou
commented
Jan 13, 2026
krassowski
reviewed
Jan 13, 2026
krassowski
approved these changes
Jan 14, 2026
Member
krassowski
left a comment
There was a problem hiding this comment.
Let's try it! Thank you @martinRenou!
krassowski
reviewed
Jan 14, 2026
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots-checkout@main |
Member
There was a problem hiding this comment.
Long-term we might want to version this.
jasongrout
pushed a commit
that referenced
this pull request
Feb 21, 2026
#18550) ## References Follow-up to #18334, we updated the main `update-galata-snapshots` job but not the `update-documentation-snapshots` job. Tested on krassowski#160: - expected pass on https://github.com/krassowski/jupyterlab/actions/runs/22254396411/job/64383156972 - expected fail on https://github.com/krassowski/jupyterlab/actions/runs/22254293312/job/64382916187 (header application via bot modified the branch) ## Code changes Use `maintainer-tools/update-snapshots-checkout` for setup of the update action. ## User-facing changes None ## Backwards-incompatible changes None ## AI usage No --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would fix #17764