Add Kotlin snippets for six User Guide sections#5432
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
marcphilipp
reviewed
Mar 6, 2026
marcphilipp
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR! I left a few comments/questions inline.
- Add Kotlin examples for Nested Tests documentation - Add Kotlin examples for Dynamic Tests documentation - Add Kotlin examples for Assumptions documentation - Add Kotlin examples for Exception Handling documentation - Add Kotlin examples for Repeated Tests documentation - Add Kotlin examples for Test Classes and Methods documentation - Wrap existing Java code blocks in tabbed snippets (Java/Kotlin) --------- Signed-off-by: Anton.Yalyshev <yalishev.ant@gmail.com>
2ef4afc to
da2d5bd
Compare
✅ All tests passed ✅🏷️ Commit: da2d5bd Learn more about TestLens at testlens.app. |
Contributor
Author
|
Thanks for the review! I've addressed all the comments:
By the way - was six pages a reasonable scope for one PR, or would you prefer smaller/larger batches going forward? |
Member
I think that's a good size. If you'd prefer slightly larger to reduce the time you have to wait for my reviews, I'd be fine with that, though. |
marcphilipp
approved these changes
Mar 9, 2026
yalishevant
added a commit
to yalishevant/junit-framework
that referenced
this pull request
Apr 8, 2026
Add tabbed Java/Kotlin code examples to ten documentation pages, continuing the effort started in junit-team#5316 and junit-team#5432. Pages updated (Writing Tests): - Built-in Extensions (@tempdir, @autoclose, Locale/TimeZone, SystemProperty) - Conditional Test Execution - Display Names - Annotations - Timeouts - Test Interfaces and Default Methods Pages updated (Extensions): - Parameter Resolution - Keeping State in Extensions - Test Lifecycle Callbacks - Registering Extensions Issue: junit-team#5266 Signed-off-by: Anton.Yalyshev <yalishev.ant@gmail.com>
yalishevant
added a commit
to yalishevant/junit-framework
that referenced
this pull request
Apr 8, 2026
Add tabbed Java/Kotlin code examples to ten documentation pages, continuing the effort started in junit-team#5316 and junit-team#5432. Pages updated (Writing Tests): - Built-in Extensions (@tempdir, @autoclose, Locale/TimeZone, SystemProperty) - Conditional Test Execution - Display Names - Annotations - Timeouts - Test Interfaces and Default Methods Pages updated (Extensions): - Parameter Resolution - Keeping State in Extensions - Test Lifecycle Callbacks - Registering Extensions Issue: junit-team#5266 Signed-off-by: Anton.Yalyshev <yalishev.ant@gmail.com>
4 tasks
yalishevant
added a commit
to yalishevant/junit-framework
that referenced
this pull request
Apr 9, 2026
Add tabbed Java/Kotlin code examples to ten documentation pages, continuing the effort started in junit-team#5316 and junit-team#5432. Pages updated (Writing Tests): - Built-in Extensions (@tempdir, @autoclose, Locale/TimeZone, SystemProperty) - Conditional Test Execution - Display Names - Annotations - Timeouts - Test Interfaces and Default Methods Pages updated (Extensions): - Parameter Resolution - Keeping State in Extensions - Test Lifecycle Callbacks - Registering Extensions Signed-off-by: Anton.Yalyshev <yalishev.ant@gmail.com>
marcphilipp
added a commit
that referenced
this pull request
Apr 23, 2026
Add tabbed Java/Kotlin code examples to ten documentation pages, continuing the effort started in #5316 and #5432. Pages updated (Writing Tests): - Built-in Extensions (@tempdir, @autoclose, Locale/TimeZone, SystemProperty) - Conditional Test Execution - Display Names - Annotations - Timeouts - Test Interfaces and Default Methods Pages updated (Extensions): - Parameter Resolution - Keeping State in Extensions - Test Lifecycle Callbacks - Registering Extensions --------- Signed-off-by: Anton.Yalyshev <yalishev.ant@gmail.com> Co-authored-by: Marc Philipp <mail@marcphilipp.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Kotlin tabbed code snippets to six more User Guide sections,
continuing the effort started in #5316.
Pages updated:
Each Java code block is wrapped in
[tabs]with a correspondingKotlin example that mirrors the same test logic using idiomatic
Kotlin: property access, string templates, reified generics,
trailing lambdas,
companion object+@JvmStaticfor lifecyclemethods, etc.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
Method preconditions are checked(N/A — documentation only)Public API has Javadoc and(N/A — documentation only)@APIannotations