cleanup(cache): remove dead TieredCacheManager#1422
Merged
Conversation
f36c217 to
344799b
Compare
Verified unused: zero instantiations across the entire git history
(`git log -S 'TieredCacheManager('` returns only the initial-commit
declaration), zero imports outside the module's own __init__ re-export,
zero test references. The class was a planned coordinator between
PagedCacheManager / BlockAwarePrefixCache / PagedSSDCacheManager /
MemoryMonitor — Scheduler.__init__ does that wiring directly, making
the abstraction redundant.
Removes 353 lines plus the re-export from omlx.cache.__all__.
344799b to
0196c89
Compare
Owner
|
Thanks for the cleanup! Verified all four claims independently. Zero instantiations in git history, no external imports, no test references, and Scheduler.init wires PagedCacheManager / BlockAwarePrefixCache / PagedSSDCacheManager directly today. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TieredCacheManageris unused: zero instantiations across git history (git log -S 'TieredCacheManager('returns only the initial-commit declaration), zero imports outside the module's own__init__re-export, zero test references. The class was a planned coordinator betweenPagedCacheManager/BlockAwarePrefixCache/PagedSSDCacheManager/MemoryMonitor— butScheduler.__init__does that wiring directly today, making the abstraction redundant.Removes 353 lines from
omlx/cache/tiered_manager.pyplus the re-export fromomlx/cache/__all__.Test plan
from omlx.cache import PagedCacheManager, PagedSSDCacheManager, BlockAwarePrefixCachestill importspytest tests/test_paged_ssd_cache.py tests/test_paged_cache.py— 156 passed