fix(tests): update Scheduler/Memory to_dict expectations for new fields#1286
Merged
jundot merged 1 commit intoMay 19, 2026
Conversation
Test assertions for SchedulerSettings.to_dict and MemorySettings.to_dict omitted the chunked_prefill, soft_threshold, and hard_threshold fields that the to_dict implementations already emit. The tests would fail the moment anyone ran them locally with the current defaults. Update the expected dicts to match the current implementation. Fixes jundot#1259
panwudi
pushed a commit
to panwudi/flyto-mlx
that referenced
this pull request
May 18, 2026
Failures pre-date this branch (upstream issue jundot#1259 cluster) but were not covered by upstream jundot#1268/jundot#1286/jundot#1287 because they track flyto's own divergence: - model_profiles: classify dflash_max_concurrent / dflash_kv_pressure_threshold (flyto dflash Path A fields, beyond upstream jundot#1268's 9) - test_omlx_app: server_manager auto-restart cap was lifted 3 -> 10000 (3bed072); update the constant assertion and the give-up test - test_vlm_engine: _prepare_vision_inputs gained an audios kwarg Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
|
Thanks for the cleanup. The defaults in |
cfbraun
added a commit
to cfbraun/omlx
that referenced
this pull request
May 19, 2026
Closes a long-standing gap noticed during the upstream merge: the class ships full to_dict/from_dict but had no tests, so field drift would have gone unnoticed (cf. upstream jundot#1286 which had to retrofit the same coverage for SchedulerSettings/MemorySettings).
cfbraun
added a commit
to cfbraun/omlx
that referenced
this pull request
May 26, 2026
Closes a long-standing gap noticed during the upstream merge: the class ships full to_dict/from_dict but had no tests, so field drift would have gone unnoticed (cf. upstream jundot#1286 which had to retrofit the same coverage for SchedulerSettings/MemorySettings).
cfbraun
added a commit
to cfbraun/omlx
that referenced
this pull request
May 26, 2026
upstream acd0533 added max_process_memory_is_explicit, prefill_safe_zone_ratio, and prefill_min_chunk_tokens to MemorySettings.to_dict() but the to_dict test was not updated (last touched in jundot#1286 on 2026-05-19, predating acd0533 by a week). The test was already failing on upstream/main — this just closes the gap.
Contributor
Author
|
Big thanks @jundot - getting the to_dict test expectations in sync with the chunked_prefill / soft/hard_threshold fields unblocks local runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchedulerSettings.to_dict()andMemorySettings.to_dict()emit several fields (chunked_prefill,soft_threshold,hard_threshold) that their corresponding tests intests/test_settings.pydidn't include in the expected dict. The tests fail locally against current defaults. Updates the expected dicts to match the implementation.Why this matters
#1259 surfaced the staleness in passing. Test failures in this area mask any real regression in the settings serialization path.
Changes
tests/test_settings.py- updateto_dictexpectations for SchedulerSettings and MemorySettings to include the missing fields.Testing
Tests pass locally after the update; no other test changes needed.
Fixes #1259