Skip to content

Fix bonus tokens by function adjustavailableTokens (#31)#31

Merged
manadart merged 2 commits intojuju:masterfrom
kingsamchen:fix/adjustAvailableToken
Oct 2, 2019
Merged

Fix bonus tokens by function adjustavailableTokens (#31)#31
manadart merged 2 commits intojuju:masterfrom
kingsamchen:fix/adjustAvailableToken

Conversation

@kingsamchen
Copy link
Contributor

Once adjustavailableTokens() is called, the number of tokens should be
updated in accordance with the tick even if the buket is full.

Semantically, extra tokens are discarded though we, in fact, simply
returns from the function.

Once adjustavailableTokens() is called, the number of tokens should be
updated in accordance with the tick even if the buket is full.

Semantically, extra tokens are discarded though we, in fact, simply
returns from the function.
Copy link
Member

@manadart manadart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this.

@manadart
Copy link
Member

manadart commented Oct 2, 2019

$$merge$$

Edit: No bot merging manually.

@manadart manadart merged commit f60b320 into juju:master Oct 2, 2019
@manadart manadart changed the title Fix bonus tokens by function adjustavailableTokens (#30) Fix bonus tokens by function adjustavailableTokens (#31) Oct 2, 2019
jujubot added a commit to juju/juju that referenced this pull request Oct 2, 2019
#10671

## Description of change

Updates the _juju/ratelimit_ dependency, which just received a bug-fix.

See: juju/ratelimit#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants