Replace new Function() with regular function#236
Closed
budnix wants to merge 1 commit intojstat:masterfrom
budnix:csp-violation-fix
Closed
Replace new Function() with regular function#236budnix wants to merge 1 commit intojstat:masterfrom budnix:csp-violation-fix
budnix wants to merge 1 commit intojstat:masterfrom
budnix:csp-violation-fix
Conversation
Using `eval` or `new Function` violates Content Security Policy (CSP).
This was referenced Oct 24, 2018
|
@trevnorris hi man sorry to bug you – any chance this is getting merged soon? it will allow folks with content security policy to use this package (csp will by default block all "eval") |
|
👍 |
|
@AMBudnik guys, if we fork this repo, could you potentially point toward a custom fork? |
|
I've had a discussion with the team and we'd rather create a fork cause then we'd have a 100% control over it, however, it takes more effort (maintaining, pull requests, issues, security updates...). We're already building a new formula engine so or connection to jStat may end. Maybe @mrwillihog could help us? |
trevnorris
pushed a commit
that referenced
this pull request
Jun 3, 2019
Using `eval` or `new Function` violates Content Security Policy (CSP). PR-URL: #236 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Member
|
Glad to see you back in the game @trevnorris 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes:
vowsdoesn't work with this project so I've locked latest worked version. Now tests pass;new Function()expression which violates Content Security Policy (CSP).I didn't include
/distfiles because I don't know what is the release flow of this library. If you want this files I can build and include them to this PR.