Conversation
wmdietl
commented
Apr 25, 2024
| @@ -65,6 +65,12 @@ void catchParameters() { | |||
| // test:irrelevant-annotation:NonNull | |||
Collaborator
Author
There was a problem hiding this comment.
Should there be different tests for "irrelevant" vs. "intrinsically non-null"?
Collaborator
There was a problem hiding this comment.
We've been using irrelevant-annotation for all cases where the annotation is unrecognized or inapplicable, without requiring tools to distinguish.
netdpb
requested changes
Jun 24, 2024
| @@ -65,6 +65,12 @@ void catchParameters() { | |||
| // test:irrelevant-annotation:NonNull | |||
Collaborator
There was a problem hiding this comment.
We've been using irrelevant-annotation for all cases where the annotation is unrecognized or inapplicable, without requiring tools to distinguish.
Co-authored-by: David P. Baker <dpb@google.com>
netdpb
approved these changes
Jun 27, 2024
Collaborator
|
@wmdietl are you waiting for something before you squash-and-merge? |
Collaborator
Author
Thanks for the ping. |
cpovirk
added a commit
to jspecify/jspecify-reference-checker
that referenced
this pull request
Jul 9, 2024
This hasn't happened automatically, as discussed in #184.
cpovirk
added a commit
to jspecify/jspecify-reference-checker
that referenced
this pull request
Jul 9, 2024
This hasn't happened automatically, as discussed in #184.
wmdietl
added a commit
to jspecify/jspecify-reference-checker
that referenced
this pull request
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to the discussion in #347.
This PR updates the spec and completes the conformance tests.