Fix issue when http headers are already present#843
Merged
DannyvdSluijs merged 2 commits intojsonrainbow:masterfrom Sep 9, 2025
Merged
Fix issue when http headers are already present#843DannyvdSluijs merged 2 commits intojsonrainbow:masterfrom
DannyvdSluijs merged 2 commits intojsonrainbow:masterfrom
Conversation
Collaborator
|
I’noticed the same also. I’ll have a look this weekend or next week. Would that be ok, or do you need this fixed sooner? If you could add an entry in the changelog that would help in getting it merged faster. |
Contributor
Author
|
No rush at all, I've downgraded already :) |
DannyvdSluijs
approved these changes
Sep 9, 2025
Contributor
Author
|
Thanks for wrapping it up for me |
Copilot AI
added a commit
that referenced
this pull request
Feb 27, 2026
Co-authored-by: DannyvdSluijs <618940+DannyvdSluijs@users.noreply.github.com>
DannyvdSluijs
added a commit
that referenced
this pull request
Feb 27, 2026
12 tasks
DannyvdSluijs
added a commit
that referenced
this pull request
Feb 27, 2026
…ch (#893) ## Description See #843 ## Related Issue Port of #843 Fixes #860 Replaces #888 ## Type of Change <!-- Mark the appropriate option with an "x" --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Code refactoring - [ ] Other (please describe): ## Checklist <!-- Mark completed items with an "x" --> - [x] I have read the [CONTRIBUTING](CONTRIBUTING.md) guidelines - [x] My code follows the code style of this project - [x] I have added tests that prove my fix is effective or that my feature works - [x] All new and existing tests pass - [x] I have updated the documentation accordingly - [x] My changes generate no new warnings ## Additional Notes <!-- Add any additional information that might be helpful for reviewers -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #841
If a process/request runs:
http_get_last_response_headers()is availableThen you end up with:
$this->fetchContentType()will fail unless the response headers were of the correctapplication/schema+jsonmime type (which is very unlikely).So this PR clears the headers before we fetch the schema, to make sure we have a clean slate. I'll probably report this to PHP as well because IMO it is a bit surprising.