Conversation
|
@andypost thanks for the contribution. The pipeline fails on a welcome message which isn’t important. I’ll try to merge and release Friday. I’ll add a small comment next to the added line which explains why we do this (because of BC compatibility) and add an line to the changelog. Or if you could do this in the meantime, merging the PR would be easier. |
|
Thank you! added comment but I did not get how to fix welcome message |
The welcome message isn't important. It isn't because of this PR but rather something else I need to checkout. Looks great. Will merge tomorrow. |
|
@andypost apparently write access to the fork has been blocked meaning I can't push the addition to the changelog. #841 replaces this PR whilst keeping your commits. |
Replaces #840 (due to blocked write access on fork) --------- Co-authored-by: Andy Postnikov <apostnikov@gmail.com>
https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_http_response_header_predefined_variable
related to #798