Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jsonrainbow/json-schema
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.4.1
Choose a base ref
...
head repository: jsonrainbow/json-schema
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.4.2
Choose a head ref
  • 7 commits
  • 14 files changed
  • 3 contributors

Commits on Apr 11, 2025

  1. Fix objects are non unique despite key order (#819)

    As pointed out by the [bowtie
    report](https://bowtie.report/#/dialects/draft4?language=php) there
    where some issues when validating the uniqueness of values espec. when
    the order of the keys was different.
    DannyvdSluijs authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    0f69f0e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2025

  1. Update UPGRADE-6.0.md (#823)

    Add missing breaking change to upgrade guide
    
    Fixes #822
    
    ---------
    
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    bbrala and Copilot authored May 5, 2025
    Configuration menu
    Copy the full SHA
    708a160 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2025

  1. Update constraint class to PHP 7.2 language level (#824)

    This brings the `Constraint` class to PHP 7.2 language level and does
    some cleanup along the way.
    DannyvdSluijs authored May 6, 2025
    Configuration menu
    Copy the full SHA
    13c5e8d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2025

  1. ci: add 32-bits ci workflow (#825)

    This pull request introduces a new GitHub Actions workflow for
    continuous integration on a 32-bit system. The workflow is configured to
    run tests using PHP 8.4 and includes steps for environment setup and
    test execution.
    
    ### New Continuous Integration Workflow:
    
    *
    [`.github/workflows/continuous-integration-32-bit.yml`](diffhunk://#diff-913f89970936b1231274367aff0161dfd9c5ca768783bdf9d1e1961b59aad86eR1-R38):
    Added a new workflow named "Continuous Integration" that triggers on
    `push` and `pull_request` events targeting the `master` branch. It runs
    on `ubuntu-latest` using a 32-bit container
    (`shivammathur/node:latest-i386`) and sets up PHP 8.4 with specific
    extensions, tools, and configuration before executing tests via
    `composer test`.
    
    Fixes #818
    DannyvdSluijs authored May 7, 2025
    Configuration menu
    Copy the full SHA
    95e5d61 View commit details
    Browse the repository at this point in the history
  2. refactor: update BaseConstraint.php to PHP 7.2 language level (#826)

    This pull request refactors the `BaseConstraint` class in the
    `JsonSchema` package to improve code readability, enforce immutability,
    and align with modern PHP practices. The changes include replacing
    anonymous functions with static closures, updating type casting, and
    removing outdated comments.
    
    ### Code modernization and immutability:
    
    * Replaced anonymous functions with `static` closures in methods like
    `addError`, `addErrors`, and `convertJsonPointerIntoPropertyPath` to
    enforce immutability and improve performance.
    [[1]](diffhunk://#diff-05cd63f6b003f185a215e10402525e33d94466ec4d83a685c5a6ccd1befcf921L53-R48)
    [[2]](diffhunk://#diff-05cd63f6b003f185a215e10402525e33d94466ec4d83a685c5a6ccd1befcf921L81-R75)
    [[3]](diffhunk://#diff-05cd63f6b003f185a215e10402525e33d94466ec4d83a685c5a6ccd1befcf921L167-R162)
    * Updated type casting for better readability and adherence to modern
    PHP conventions, e.g., `(string)` instead of `strval`.
    
    ### Code readability and cleanup:
    
    * Removed outdated docblock comments and unnecessary annotations, such
    as the `@return` tag in `convertJsonPointerIntoPropertyPath`.
    * Replaced `\JSON_ERROR_NONE` with the `JSON_ERROR_NONE` constant for
    consistency with the `use` statement.
    
    ### Other improvements:
    
    * Adjusted the `json_decode` call to explicitly set the `associative`
    parameter to `false` for clarity.
    DannyvdSluijs committed May 7, 2025
    Configuration menu
    Copy the full SHA
    b209eb8 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2025

  1. Fix #827 (#828)

    This PR will:
    - Scan schemas that are being added for `id` properties and register
    them if valid schemas
    - Avoid altering the `id` for sibling `ref` properties
    - Don't register schema or expand refs when found in enum or const
    
    This will fix #827
    DannyvdSluijs authored Jun 3, 2025
    Configuration menu
    Copy the full SHA
    ac58d3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce1fd2d View commit details
    Browse the repository at this point in the history
Loading