Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #827 by enhancing schema scanning and preventing unintended alterations to sibling ref properties. Key changes include:
- Updating function signatures with strict type hints and return types in both SchemaStorageInterface and SchemaStorage.
- Switching to strict equality (===) for schema id comparisons.
- Adding a recursive subschema registration method in SchemaStorage to scan for nested id properties.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/JsonSchema/SchemaStorageInterface.php | Updated function signatures with type hints and return types. |
| src/JsonSchema/SchemaStorage.php | Enhanced addSchema and expandRefs methods for better reference resolution and introduced subschema registration. |
| phpstan-baseline.neon | Adjusted baseline messages to reflect type validations and return type updates. |
| CHANGELOG.md | Updated changelog with new issue fix information. |
Comments suppressed due to low confidence (1)
src/JsonSchema/SchemaStorage.php:105
- [nitpick] The variable names '$parentId' and '$childId' are used to manage schema reference resolution; adding a brief comment or using more descriptive names may improve clarity for future maintainers.
if (property_exists($schema, 'id') && is_string($schema->id) && $childId !== $schema->id) {
|
Hello DannyvdSluijs, I encountered the error message Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
idproperties and register them if valid schemasidfor siblingrefpropertiesThis will fix #827