Native aot stj8#640
Merged
Merged
Conversation
Collaborator
Author
|
I think I'm going to keep the multitarget in the project files. There are still a few things (like |
gregsdennis
added a commit
that referenced
this pull request
Jan 30, 2024
Contributor
|
Multi-targeting also enables us to run tests reflection enabled and disabled, so that's also handy. |
jevansaks
reviewed
Jan 30, 2024
jevansaks
reviewed
Jan 30, 2024
Contributor
Collaborator
Author
I think this'll go in another PR. |
jevansaks
reviewed
Jan 30, 2024
| #pragma warning disable IL2026, IL3050 | ||
| // using the options.Write() extension here for some reason causes a StackOverflow | ||
| JsonSerializer.Serialize(writer, rule, rule.GetType(), LogicSerializerContext.OptionsManager.SerializerOptions); | ||
| options.Write(writer, rule, rule.GetType()); |
Contributor
There was a problem hiding this comment.
FYI still need to use Suppression attributes instead of #pragma warning disable because library consumers don't see the #pragma warning and the callers will get AOT warnings on our code. The AOT analyzer only sees attributes so we need to suppress that way. See #636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still has issues with
doublein netcoreapp3.1. Not sure what to do there.Also supposedly we can stop targeting net8 directly and just use netstandard 2. I'll try that.