feat: Use constructor(…) operation instead of extended attribute#153
Merged
TimothyGu merged 4 commits intojsdom:masterfrom Dec 31, 2019
Merged
feat: Use constructor(…) operation instead of extended attribute#153TimothyGu merged 4 commits intojsdom:masterfrom
constructor(…) operation instead of extended attribute#153TimothyGu merged 4 commits intojsdom:masterfrom
Conversation
89fad38 to
0a85ef7
Compare
domenic
requested changes
Dec 22, 2019
domenic
requested changes
Dec 22, 2019
pmdartus
approved these changes
Dec 30, 2019
TimothyGu
reviewed
Dec 30, 2019
Member
TimothyGu
left a comment
There was a problem hiding this comment.
Code LGTM. You should also update the README and potentially other places (comments?) to account for this change.
TimothyGu
approved these changes
Dec 31, 2019
Member
|
@ExE-Boss Would you be willing to help migrate jsdom to use this new syntax? |
Contributor
Author
|
@TimothyGu Done in: jsdom/jsdom#2765. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #131
review?(@pmdartus, @domenic)