Use constructor(…) operation instead of extended attribute#2765
Closed
ExE-Boss wants to merge 1 commit intojsdom:masterfrom
Closed
Use constructor(…) operation instead of extended attribute#2765ExE-Boss wants to merge 1 commit intojsdom:masterfrom
constructor(…) operation instead of extended attribute#2765ExE-Boss wants to merge 1 commit intojsdom:masterfrom
Conversation
ExE-Boss
commented
Dec 31, 2019
TimothyGu
reviewed
Jan 1, 2020
Member
TimothyGu
left a comment
There was a problem hiding this comment.
Looks good, though we’ll hold off on merging this till webidl2js with some more of the pending PRs gets released.
Member
|
I am unable to push fixup commits to this branch (I guess "allow edits from maintainers" is not checked), so I will open a new PR. |
Contributor
Author
|
@domenic It is checked, but GitHub has weird issues with it and repository forks hosted on organisations. |
constructor(…) operation instead of extended attributeconstructor(…) operation instead of extended attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @TimothyGu in jsdom/webidl2js#153.