Update style-set-property.html regression test#4010
Merged
domenic merged 1 commit intojsdom:mainfrom Jan 2, 2026
Merged
Conversation
domenic
approved these changes
Jan 2, 2026
domenic
pushed a commit
to jsdom/cssstyle
that referenced
this pull request
Jan 2, 2026
The previous string conversion was over-complicated, and did not match the specs in that it threw TypeErrors unnecessarily. See #129 and jsdom/jsdom#4010.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test case for jsdom/cssstyle#129