Conversation
|
Ahh, the UI Events spec supplements the Event spec and specifically saves the modifier keys which is not originally in there. However, I don't think they should be exposed like that, at least I can't find the IDL for it. They should only be retrievable via Re webidl2js: I'm not sure what the best choice would be there. I think it'd make sense for the impl class to provide defaults, I think it makes sense to require other impl class to know about the required impl args, and it also makes sense to just use the public constructur if you want to use these convenience features. I think there's a point to make for all of these choices. |
|
We ended up with a very similar problem in the specs, resulting in https://dom.spec.whatwg.org/#concept-event-create. So I should implement that :) |
Fixes jsdom#1559. Closes jsdom#1629.
Fixes jsdom#1559. Closes jsdom#1629.
Fixes jsdom#1559. Closes jsdom#1629.
Fixes jsdom#1559. Closes jsdom#1629.
Fixes jsdom#1559. Closes jsdom#1629.
Fixes jsdom#1559. Closes jsdom#1629.
Even with this fix (which is not super-satisfying, since the impl side should ideally only ever have to deal with impls) it looks like only the basic Event values and the MouseEventInit values are getting correctly initialized; the rest are undefined. @Sebmaster, thoughts?