Skip to content

Attempt at fixing #1559#1629

Closed
domenic wants to merge 2 commits intomasterfrom
mousevent-click-init-problems
Closed

Attempt at fixing #1559#1629
domenic wants to merge 2 commits intomasterfrom
mousevent-click-init-problems

Conversation

@domenic
Copy link
Member

@domenic domenic commented Oct 16, 2016

Even with this fix (which is not super-satisfying, since the impl side should ideally only ever have to deal with impls) it looks like only the basic Event values and the MouseEventInit values are getting correctly initialized; the rest are undefined. @Sebmaster, thoughts?

@Sebmaster
Copy link
Member

Ahh, the UI Events spec supplements the Event spec and specifically saves the modifier keys which is not originally in there. However, I don't think they should be exposed like that, at least I can't find the IDL for it. They should only be retrievable via getModifierState.

Re webidl2js: I'm not sure what the best choice would be there. I think it'd make sense for the impl class to provide defaults, I think it makes sense to require other impl class to know about the required impl args, and it also makes sense to just use the public constructur if you want to use these convenience features. I think there's a point to make for all of these choices.

@domenic
Copy link
Member Author

domenic commented Oct 24, 2016

We ended up with a very similar problem in the specs, resulting in https://dom.spec.whatwg.org/#concept-event-create. So I should implement that :)

@domenic domenic mentioned this pull request Dec 24, 2017
TimothyGu added a commit to TimothyGu/jsdom that referenced this pull request Dec 26, 2017
TimothyGu added a commit to TimothyGu/jsdom that referenced this pull request Dec 26, 2017
TimothyGu added a commit to TimothyGu/jsdom that referenced this pull request Dec 26, 2017
TimothyGu added a commit to TimothyGu/jsdom that referenced this pull request Dec 29, 2017
TimothyGu added a commit to TimothyGu/jsdom that referenced this pull request Jan 8, 2018
TimothyGu added a commit to TimothyGu/jsdom that referenced this pull request Jan 16, 2018
@domenic domenic closed this in 71d869d Jan 16, 2018
@domenic domenic deleted the mousevent-click-init-problems branch January 22, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants