Closed
Conversation
I did this by cloning the repo, running npm install, and then executing the following command: ```sh node scripts/download_latest_properties.js ``` Finally, I ran eslint autofix on the file, which mostly just reformatted the quotes from doubles to singles. I hope that updating this file will allow JSDOM to avoid stripping these valid styles from style attributes on DOM nodes.
Author
|
We've tested this change at Airbnb by using patch package and it seems to resolve some issues we were running into with this list being outdated. |
domenic
added a commit
that referenced
this pull request
Jan 22, 2023
This includes: * A replacement of cssom with rrweb-cssom, matching jsdom/jsdom#3497. Closes #153. * An update to the download_latest_properties.js script to stop using request. * A regeneration of the list of properties. Closes #150. * Some style updates to most generated files, for unclear reasons.
domenic
added a commit
that referenced
this pull request
Jan 22, 2023
This includes: * A replacement of cssom with rrweb-cssom, matching jsdom/jsdom#3497. Closes #153. * An update to the download_latest_properties.js script to stop using request. * A regeneration of the list of properties. Closes #150. * Some style updates to most generated files, for unclear reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did this by cloning the repo, running npm install, and then executing
the following command:
Finally, I ran eslint autofix on the file, which mostly just reformatted
the quotes from doubles to singles.
I hope that updating this file will allow JSDOM to avoid stripping these
valid styles from style attributes on DOM nodes.