Skip to content
This repository was archived by the owner on Mar 23, 2024. It is now read-only.

Add validateQuoteMarks rule, closes #106#118

Merged
mdevils merged 1 commit intojscs-dev:masterfrom
mikesherov:quotmark
Dec 30, 2013
Merged

Add validateQuoteMarks rule, closes #106#118
mdevils merged 1 commit intojscs-dev:masterfrom
mikesherov:quotmark

Conversation

@mikesherov
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikesherov IMO there should be tests checking for ' inside " & vice versa, like:

var x = "'x'";

with validateQuoteMarks: '"'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikesherov
Copy link
Copy Markdown
Contributor Author

@mzgol good point. I'll add

mdevils added a commit that referenced this pull request Dec 30, 2013
Add validateQuoteMarks rule, closes #106
@mdevils mdevils merged commit b841e94 into jscs-dev:master Dec 30, 2013
@mikesherov mikesherov deleted the quotmark branch December 30, 2013 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants