Merged
Conversation
e438f4e to
194c732
Compare
d3d25e0 to
19caadd
Compare
When calling "Cookies.withConverter", you can pass either a function to use as the read converter, or an Object Literal with the properties "read" and "write".
7e628d2 to
ecc1386
Compare
Member
Author
|
(@dezlov, it seems that your comment was removed from this PR on rebase, so I will replicate here:) @dezlov:
In PHP, use setrawcookie($name, rawurlencode($value)); |
Member
Author
I didn't tested it either. It is just a reference documentation to workaround server-side incompatibilities based in PHP docs and Tomcat's source code.
I will add that |
It might be easier for someone to spot what this file is for when downloading through a package manager.
Otherwise "legit" encoded pluses will be replaced incorrectly This is based on @nanaya's comment at #70 (comment)
Member
Author
Those snippets are not unit tested. Therefore they should only serve as a reference for a custom implementation.
ea9840b to
f72d1bf
Compare
Only document the "read converter" as a property when using along with the "write converter".
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
Cookies.withConverter, you can pass either a function touse as the read converter, or an Object Literal with the properties
readandwrite.