Closed
Conversation
cbd3f63 to
97cc08d
Compare
Member
Author
|
This will require some additional work to support our URI path forms. We may need to continue overriding more of the pure-Ruby logic than I'd hoped. |
* RubyPathname is stripped down to match the remaining extension in CRuby 3.5 (<=> and sub). * RubyPathname.path field is bound to @path instance variable. * pathname.rb comes from ruby/pathname, with undef preamble, extension load, and a few utility methods removed. * stdlib pathname.rb contains those utility methods. See ruby/pathname#57 and ruby/pathname#17 Fixes jruby#9060
headius
added a commit
that referenced
this pull request
Feb 24, 2026
Ideally we would be able to use the same pure-Ruby sources as the gem (see #9062) but there are additional tweaks needed there to support our URI forms. For now we just internalize our existing implementation to get things working. See ruby/pathname#57 and ruby/pathname#17 for the Pathname move in Ruby 4.0 and #9060 for our issue to switch to the pure- Ruby version.
Member
Author
|
Because of the missing URI support, I've temporarily just internalized the existing implementation we already had. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ruby/pathname#57 and ruby/pathname#17
Fixes #9060