Skip to content

Fix Dir.glob with cases#6681

Merged
enebo merged 2 commits intojruby:masterfrom
edipofederle:fix-dir-glob-with-case
Jun 3, 2021
Merged

Fix Dir.glob with cases#6681
enebo merged 2 commits intojruby:masterfrom
edipofederle:fix-dir-glob-with-case

Conversation

@edipofederle
Copy link
Copy Markdown
Contributor

@edipofederle edipofederle commented May 23, 2021 •
edited
Loading

Hi,

This PR updates the addToResultIfExists Java method in order to handle the correct file name in the file system. It should close this issue: #2150.

note: This is my attempt to achieve my first contribution to JRuby, so any feedback here would be great.

Thanks

@edipofederle edipofederle force-pushed the fix-dir-glob-with-case branch 2 times, most recently from 373be23 to 328ac39 Compare May 23, 2021 19:15
@headius
Copy link
Copy Markdown
Member

headius commented May 26, 2021

Looks like some valid problems in the travis run... are you able to run those suites locally to reproduce?

@headius headius marked this pull request as draft June 1, 2021 22:42
@headius
Copy link
Copy Markdown
Member

headius commented Jun 1, 2021

Converted to a draft while you try to work out issues. Thanks for digging into this!

Whenever we do merge I will probably have to squash your commits to get right of the "try again". If you can restructure the commits and do a force push to clean it up, then we can keep more of the history intact.

@edipofederle
Copy link
Copy Markdown
Contributor Author

edipofederle commented Jun 1, 2021

Converted to a draft while you try to work out issues. Thanks for digging into this!

Whenever we do merge I will probably have to squash your commits to get right of the "try again". If you can restructure the commits and do a force push to clean it up, then we can keep more of the history intact.

Thanks! Yes, sorry for the 'try again' commits, I think I can clean up once I finished it.

@edipofederle edipofederle force-pushed the fix-dir-glob-with-case branch from d1c59df to 10bc51c Compare June 1, 2021 23:06
@edipofederle
Copy link
Copy Markdown
Contributor Author

edipofederle commented Jun 1, 2021

Looks like some valid problems in the travis run... are you able to run those suites locally to reproduce?

Hi, I'm enable to run, but with some errors, maybe I can share the issues I had locally ?

@edipofederle edipofederle force-pushed the fix-dir-glob-with-case branch from baf1bc0 to e901a14 Compare June 3, 2021 14:17
@edipofederle
Update addToResultIfExists` method to use real file system name. Eg: …
7bbc78e 
…if adding a file as `myfile` and the file is called MyFile` the name considered will be MyFile. It fixes some failing tests for `Dir.glob`
@edipofederle edipofederle force-pushed the fix-dir-glob-with-case branch from e901a14 to 7bbc78e Compare June 3, 2021 14:47
@edipofederle edipofederle marked this pull request as ready for review June 3, 2021 15:39
@edipofederle edipofederle marked this pull request as draft June 3, 2021 16:37
@edipofederle edipofederle force-pushed the fix-dir-glob-with-case branch from 9c20808 to d921bdd Compare June 3, 2021 17:00
@headius headius added this to the JRuby 9.3.0.0 milestone Jun 3, 2021
@enebo enebo marked this pull request as ready for review June 3, 2021 18:41
@enebo enebo merged commit 738c71b into jruby:master Jun 3, 2021
@enebo
Copy link
Copy Markdown
Member

enebo commented Jun 3, 2021

@edipofederle Awesome! Thanks for your first (of many) contribution(s)! :)

@edipofederle edipofederle deleted the fix-dir-glob-with-case branch June 29, 2021 09:03
@headius headius mentioned this pull request Nov 20, 2024
Closed
danini-the-panini added a commit to danini-the-panini/jruby that referenced this pull request Dec 21, 2024
@danini-the-panini
Revert: Fix Dir.glob with cases jruby#6681
ed8f0c1
@danini-the-panini danini-the-panini mentioned this pull request Dec 21, 2024
Merged
danini-the-panini added a commit to danini-the-panini/jruby that referenced this pull request Jan 23, 2025
@danini-the-panini
Revert: Fix Dir.glob with cases jruby#6681
0627180
danini-the-panini added a commit to danini-the-panini/jruby that referenced this pull request Jan 24, 2025
@danini-the-panini
Revert: Fix Dir.glob with cases jruby#6681
c89686b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@edipofederle @headius @enebo