FIXES #235 Fix for relative require from within a gem on the classpath.#643
Merged
headius merged 1 commit intojruby:masterfrom Apr 16, 2013
Merged
Conversation
Member
|
I'd love to be able to do better testing of JRuby internals, and refactoring could certainly help. We do have a JUnit-based test for LoadService you might look at editing. I'll review your change. |
Member
|
The change looks pretty clean. I hate the fact that JVM mixes "jar:" and "jar:file:" URLs unpredictably, but this seems like a reasonable fix. Merging. |
headius
added a commit
that referenced
this pull request
Apr 16, 2013
FIXES #235 Fix for relative require from within a gem on the classpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES #235
The test for this bug is an acceptance test, I feel like testing this particular behaviour would be better as a unit test for the LoadService (or NormalSearcher), but the visibility on the internals of the LoadService make this difficult to unit test.
Should we be doing work to factor the LoadService for unit testability?